-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Swift: Add some summary queries. #10903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM. Just one description I do not fully understand.
In addition to your suggested change I've restricted the count of "Expressions" to ones with locations in code now. It turns out there's quite a lot of locationless stuff that was exaggerating the size of smaller projects (and in turn making me wonder why we weren't finding many results, taint sources etc in them). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. I guess summary queries don't need a docs review.
As far as I can tell summary queries don't usually get full |
No, let's keep it consistent with the rest of summary queries. Looks good as it is. |
I wrote these queries to assess the progress we're making identifying flow sources and sensitive expressions in real world Swift snapshots. I intend to track these things fairly often in the near-mid future, so it would be convenient to have the queries in the public repo. I don't think there's any harm in letting curious users see them as well.
It might be nice to have
LinesOfCode.ql
andLinesOfUserCode.ql
summary queries as well as all (?) other languages do, but I don't think we extract the data for them yet.