-
Notifications
You must be signed in to change notification settings - Fork 68
Closed
Labels
Difficulty-LowA false positive or false negative report which is expected to take <1 day effort to addressA false positive or false negative report which is expected to take <1 day effort to addressImpact-Mediumfalse positive/false negativeAn issue related to observed false positives or false negatives.An issue related to observed false positives or false negatives.user-reportIssue reported by an end user of CodeQL Coding StandardsIssue reported by an end user of CodeQL Coding Standards
Description
Affected rules
A13-3-1
Description
The rule title for this rule states:
A function that contains “forwarding reference” as its argument shall not be overloaded.
With the rationale saying:
Overloading functions with “forwarding reference” argument may lead to developer’s confusion on which function will be called.
Although the rule title suggests overloads with different numbers of parameters should be prohibited, there is no confusion in this case, and therefore I believe it's safe to exclude them.
Example
class foo {
public:
foo() {} // error here
template<typename T>
foo(T&&){}
};
Metadata
Metadata
Assignees
Labels
Difficulty-LowA false positive or false negative report which is expected to take <1 day effort to addressA false positive or false negative report which is expected to take <1 day effort to addressImpact-Mediumfalse positive/false negativeAn issue related to observed false positives or false negatives.An issue related to observed false positives or false negatives.user-reportIssue reported by an end user of CodeQL Coding StandardsIssue reported by an end user of CodeQL Coding Standards
Type
Projects
Status
Done