Fail processing on a 422 as well

Until there is a more robust versioning system it is probably safest to require endpoint compatiblity and not continue the action if there is a mismatch.

Author: Simon Engledew

lib/actions-util.js

@@ -298,11 +298,6 @@ function isHTTPError(arg: any): arg is HTTPError {
   return arg?.status !== undefined && Number.isInteger(arg.status);
 }
 
-function errorMessage(message: string, notFatal: boolean): boolean {
-  (notFatal ? core.warning : core.setFailed)(message);
-  return notFatal;
-}
-
 /**
  * Send a status report to the code_scanning/analysis/status endpoint.
  *
@@ -358,21 +353,32 @@ export async function sendStatusReport<S extends StatusReportBase>(
           // we should not stop the scanning process
           // on dotcom we always want to be notified if something has gone wrong
           // as this is unlikely to be a transient failure
-          return errorMessage(
-            "Invalid status report sent to code scanning.",
-            getRequiredEnvParam("GITHUB_SERVER_URL") !== GITHUB_DOTCOM_URL
-          );
+          if (getRequiredEnvParam("GITHUB_SERVER_URL") !== GITHUB_DOTCOM_URL) {
+            core.setFailed(
+              "CodeQL Action version is incompatible with the code scanning endpoint. "
+            );
+          } else {
+            core.setFailed(
+              "CodeQL Action is out-of-date. Please upgrade to the latest version of codeql-action."
+            );
+          }
+
+          return false;
       }
     }
 
     // something else has gone wrong and the request/response will be logged by octokit
     // it's possible this is a transient error and we should continue scanning if we are early in the
     // process
+    if (ignoreFailures) {
+      core.warning(
+        "An unexpected error occured when sending code scanning status report."
+      );
+      return true;
+    }
     // if we are late in the process we need to halt the action and report it
-    return errorMessage(
-      "Unexpected error when sending code scanning status report.",
-      ignoreFailures
-    );
+    core.setFailed("Failed to send code scanning status report.");
+    return false;
   }
 }