Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Fix displaying errors in GitHub pane. #2173

Merged
merged 2 commits into from
Jan 11, 2019
Merged

Conversation

grokys
Copy link
Contributor

@grokys grokys commented Jan 10, 2019

#1787 refactored InfoPanel but didn't update GitHubPaneView with its new behavior. So:

  • Don't initially set infoPanel.Visibility to Collapsed: InfoPanel will handle this itself
  • Set ShowCloseButton to show the x button to close the error

Fixes #2172
Related #2058

#1787 refactored `InfoPanel` but didn't update `GitHubPaneView` with its new behavior. So:

- Don't initialy set `infoPanel.Visibility` to `Collapsed`: `InfoPanel` will handle this itself
- Set `ShowCloseButton` to show the `x` button to close the error

Fixes #2172
Fixes #2058
@grokys grokys requested a review from jcansdale January 10, 2019 14:25
Copy link
Collaborator

@jcansdale jcansdale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I try to create a PR in a repo that I don't have permissions to push, I see the following.

image

This is a fix for #2172, but the message is a little obtuse for this to fix completely #2058. I'll update the issue and merge. 👍

@jcansdale jcansdale merged commit 6c69aed into master Jan 11, 2019
@jcansdale jcansdale deleted the fixes/2172-github-pane-errors branch January 11, 2019 12:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No error shown when creating a PR fails
2 participants