This repository was archived by the owner on Jun 21, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should not be necessary.
Unit tests require a CurrentThreadScheduler to be used, RxUI's registrations were overriding that, causing intermittent test failures.
This should now work correctly, and greatly speeds up the tests.
Sometimes unit tests were failing to find the nativate libgit2sharp binaries under ncrunch. This fixes that.
Hopefully will be less flaky now?
Codecov Report
@@ Coverage Diff @@
## master #1997 +/- ##
==========================================
- Coverage 41.7% 40.28% -1.42%
==========================================
Files 373 405 +32
Lines 16126 17347 +1221
Branches 2211 2392 +181
==========================================
+ Hits 6725 6988 +263
- Misses 8890 9837 +947
- Partials 511 522 +11
|
jcansdale
suggested changes
Oct 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can confirm this is working a lot better! 🎉
When I first tried it, I forget to update the ReactiveUI
submodule and tests were breaking all over the place. Updating the submodule turned (almost) everything green!
We still have a troublesome FilterTitleRun2
flaky test. Shall we disable it at part of this PR?
jcansdale
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one suggested change. Merge at will....
Co-Authored-By: grokys <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various unit test fixes:
TestUtils.WithScheduler(Scheduler.CurrentThread)
hacks