This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Use OpenWebSite image for View/Open on GitHub #1877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donokuda
approved these changes
Aug 27, 2018
There was a problem hiding this comment.
🙇✨
The GitHub logo is currently overloaded for different commands. This PR changes the View/Open on GitHub to use the standard OpenWebSite image.
Definitely agree on the GitHub mark being overloaded with different commands. 👍 We might want to decide on a single command for the GitHub mark, or try to avoid using it as a command icon in general.
Thanks Jamie!
jcansdale
requested review from
tinaschrepfer
and removed request for
tinaschrepfer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up commits from #1561 into separate PRs...
What this PR does
The GitHub logo is currently overloaded for different commands. This PR changes the View/Open on GitHub to use the standard
OpenWebSiteimage.Before
After
