This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Lightweight fix for PR detail view not refreshing #1359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will automatically dispose of any preview PullRequestDetailViewModel object.
Keep CA happy by making AutoDispose static.
grokys
suggested changes
Dec 4, 2017
There was a problem hiding this comment.
This code assumes there is only one active PullRequestDetailViewModel object and automatically disposes of any previous instances.
I'm afraid that's not a valid assumption, try this:
- Open a PR (let's call this PR1)
- Check out PR1's branch
- Click the PR List icon in the toolbar to go back to the list
- Open another PR (call it PR2)
- Check out PR2's branch
- Click back twice to go back to PR1
- Check out PR1's branch again
- See that it wasn't refreshed
I say for the moment, forget about removing the event subscription and I'll create a PR on top of #1346 that fixes this.
jcansdale
changed the title
PullRequestDetailViewModel will be disposed in future commit.
|
@grokys removed the auto-dispose. |
grokys
approved these changes
Dec 4, 2017
This was referenced Jan 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR listens to the
IVSGitExtservice forActiveRepositoriesChangedevents and refreshes the model.I considered extending
ITeamExplorerServiceHolder, but this code is already quite confusing and I didn't want to complicate it further.At the moment there is no obvious way to dispose of view models.
As a workaround, this code assumes there is only one activePullRequestDetailViewModelobject and automatically disposes of any previous instances.I spoke with @grokys about how this might be handled in future. A future implementation of the
GitHubpane might dispose of view models, making theAutoDisposeworkaround redundant.Fixes #1345.