Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Remove unused code. #1313

Merged
merged 2 commits into from
Nov 15, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 1 addition & 16 deletions src/GitHub.InlineReviews/ViewModels/CommentThreadViewModel.cs
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,9 @@ namespace GitHub.InlineReviews.ViewModels
/// <summary>
/// Base view model for a thread of comments.
/// </summary>
public abstract class CommentThreadViewModel : ReactiveObject, ICommentThreadViewModel, IDisposable
public abstract class CommentThreadViewModel : ReactiveObject, ICommentThreadViewModel
{
ReactiveCommand<ICommentModel> postComment;
IDisposable placeholderSubscription;

/// <summary>
/// Intializes a new instance of the <see cref="CommentThreadViewModel"/> class.
Expand Down Expand Up @@ -48,21 +47,7 @@ public ReactiveCommand<ICommentModel> PostComment
/// <inheritdoc/>
public IAccount CurrentUser { get; }

public void Dispose()
{
Dispose(true);
GC.SuppressFinalize(this);
}

/// <inheritdoc/>
public abstract Uri GetCommentUrl(int id);

protected virtual void Dispose(bool disposing)
{
if (disposing)
{
placeholderSubscription?.Dispose();
}
}
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,7 @@
using System;
using System.Linq;
using System.Reactive;
using System.Reactive.Linq;
using System.Reactive.Subjects;
using System.Threading.Tasks;
using GitHub.Api;
using GitHub.Extensions;
using GitHub.Models;
using GitHub.Services;
Expand All @@ -17,7 +14,6 @@ namespace GitHub.InlineReviews.ViewModels
/// </summary>
public class NewInlineCommentThreadViewModel : CommentThreadViewModel
{
readonly Subject<Unit> finished = new Subject<Unit>();
bool needsPush;

/// <summary>
Expand Down Expand Up @@ -116,7 +112,6 @@ async Task<ICommentModel> DoPostComment(object parameter)
File.RelativePath.Replace("\\", "/"),
diffPosition.DiffLineNumber);

finished.OnNext(Unit.Default);
return model;
}
}
Expand Down