commit-graph-format.txt: fix no-parent value

[avoidscorn]

The correct value from commit-graph.c:

#define GRAPH_PARENT_NONE 0x70000000

Signed-off-by: Conor Davis [email protected]

cc: Taylor Blau [email protected]
cc: Derrick Stolee [email protected]
cc: Conor Davis [email protected]

[gitgitgadget]

Welcome to GitGitGadget

Hi @avoidscorn, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that your Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the FreeNode IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Freenode. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

[dscho]

/allow

[gitgitgadget]

User avoidscorn is now allowed to use GitGitGadget.

WARNING: avoidscorn has no public email address set on GitHub

[derrickstolee]

I like this change, and I look forward to seeing it on the list.

[avoidscorn]

/submit

[gitgitgadget]

Error: Could not determine full name of avoidscorn

[avoidscorn]

/submit

[gitgitgadget]

Submitted as [email protected]

To fetch this version into FETCH_HEAD:

git fetch https://github.com/gitgitgadget/git pr-733/avoidscorn/graph-parent-none-doc-v1

To fetch this version to local tag pr-733/avoidscorn/graph-parent-none-doc-v1:

git fetch --no-tags https://github.com/gitgitgadget/git tag pr-733/avoidscorn/graph-parent-none-doc-v1

[gitgitgadget]

On the Git mailing list, Taylor Blau wrote (reply to this):

Hi Conor,

On Tue, Sep 15, 2020 at 04:03:53AM +0000, Conor Davis via GitGitGadget wrote:
> -      of the ith commit. Stores value 0x7000000 if no parent in that
> +      of the ith commit. Stores value 0x70000000 if no parent in that

Thnaks for fixing this up. This dates back to a9aa3c0927 (commit-graph:
fix documentation inconsistencies, 2018-06-28) which mentions the
correct value in the commit message, but uses the incorrect value in the
patch itself.

For what it's worth, I can hardly blame the author of a9aa3c0927, since
I had to flip back and forth between the two a couple of times to
convince myself which one was which.

Anyway, this is obviously correct. Thank you for your contribution!

  Reviewed-by: Taylor Blau <[email protected]>

Thanks,
Taylor

[gitgitgadget]

User Taylor Blau <[email protected]> has been added to the cc: list.

[gitgitgadget]

On the Git mailing list, Derrick Stolee wrote (reply to this):

On 9/15/2020 12:26 AM, Taylor Blau wrote:
> For what it's worth, I can hardly blame the author of a9aa3c0927,

I can!

Thanks for noticing the doc bug. May I ask why you were looking
at the format document so closely? Are you working on a new
implementation?

Thanks,
-Stolee

[gitgitgadget]

User Derrick Stolee <[email protected]> has been added to the cc: list.

[gitgitgadget]

This branch is now known as cd/commit-graph-doc.

[gitgitgadget]

This patch series was integrated into seen via git@c8428a3.

[gitgitgadget]

On the Git mailing list, Conor Davis wrote (reply to this):

On 9/15/20 7:16 AM, Derrick Stolee wrote:
> On 9/15/2020 12:26 AM, Taylor Blau wrote:
>> For what it's worth, I can hardly blame the author of a9aa3c0927,
> I can!
>
> Thanks for noticing the doc bug. May I ask why you were looking
> at the format document so closely? Are you working on a new
> implementation?

Yes, I'm adding commit-graph support to gitoxide: 
https://github.com/Byron/gitoxide/pull/21

-Conor

[gitgitgadget]

User Conor Davis <[email protected]> has been added to the cc: list.

[gitgitgadget]

This patch series was integrated into seen via git@1741f55.

[gitgitgadget]

This patch series was integrated into seen via git@70b2ec0.

[gitgitgadget]

This patch series was integrated into next via git@b0816b6.

[gitgitgadget]

This patch series was integrated into seen via git@2c75daf.

[gitgitgadget]

This patch series was integrated into seen via git@22ac061.

[gitgitgadget]

This patch series was integrated into seen via git@4c84aee.

[gitgitgadget]

This patch series was integrated into seen via git@4d51525.

[gitgitgadget]

This patch series was integrated into next via git@4d51525.

[gitgitgadget]

This patch series was integrated into master via git@4d51525.

[gitgitgadget]

Closed via 4d51525.

[Byron]

The PR mentioned above was now merged: GitoxideLabs/gitoxide#21