bisect: Removing subdirectory restrictions on git bisect

[nirmalhk7]

Given that git rebase was never prevented from running in subdirectories, it doesnt make sense to prevent git bisect to run from subdirectories as well. So subdirectory restrictions are now removed from git
bisect, i.e.: you can now run git bisect from any git subdirectory.

Signed-off-by: Nirmal Khedkar [email protected]

Thanks for taking the time to contribute to Git! Please be advised that the
Git community does not use github.com for their contributions. Instead, we use
a mailing list ([email protected]) for code submissions, code reviews, and
bug reports. Nevertheless, you can use GitGitGadget (https://gitgitgadget.github.io/)
to conveniently send your Pull Requests commits to our mailing list.

Please read the "guidelines for contributing" linked above!

[gitgitgadget]

Welcome to GitGitGadget

Hi @nirmalhk7, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that your Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

• the lines should not exceed 76 columns,
• the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
• the commit messages' body should be describing the "why?" of the change.
• Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a comment to your PR of the form /allow. A good way to find other contributors is to locate recent pull requests where someone has been /allowed:

• Search: is:pr is:open "/allow"

Both the person who commented /allow and the PR author are able to /allow you.

An alternative is the channel #git-devel on the FreeNode IRC network:

<newcontributor> I've just created my first PR, could someone please /allow me? https://github.com/gitgitgadget/git/pull/12345
<veteran> newcontributor: it is done
<newcontributor> thanks!

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

If you want to see what email(s) would be sent for a /submit request, add a PR comment /preview to have the email(s) sent to you. You must have a public GitHub email address for this.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions (while the comments and suggestions will be mirrored into the PR by GitGitGadget, you will still want to reply via mail).

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox from the Git mailing list archive (click the (raw) link), then import it into your mail program. If you use GMail, you can do this via:

curl -g --user "<EMailAddress>:<Password>" \
    --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

To iterate on your change, i.e. send a revised patch or patch series, you will first want to (force-)push to the same branch. You probably also want to modify your Pull Request description (or title). It is a good idea to summarize the revision by adding something like this to the cover letter (read: by editing the first comment on the PR, i.e. the PR description):

Changes since v1:
- Fixed a typo in the commit message (found by ...)
- Added a code comment to ... as suggested by ...
...

To send a new iteration, just add another PR comment with the contents: /submit.

Need help?

New contributors who want advice are encouraged to join [email protected], where volunteers who regularly contribute to Git are willing to answer newbie questions, give advice, or otherwise provide mentoring to interested contributors. You must join in order to post or view messages, but anyone can join.

You may also be able to find help in real time in the developer IRC channel, #git-devel on Freenode. Remember that IRC does not support offline messaging, so if you send someone a private message and log out, they cannot respond to you. The scrollback of #git-devel is archived, though.

[gitgitgadget]

There is an issue in commit dcbf148d72491826dcc9070668d5d101db1e920e:
Prefixed commit message must be in lower case: bisect: Removing subdirectory restrictions on git bisect

[dscho]

Prefixed commit message must be in lower case: bisect: Removing subdirectory restrictions on git bisect

@nirmalhk7 what GitGitGadget is trying to tell you is that "Removing" should start with a lower-case "r".

In addition, if you compare to the existing commit messages, Git's style wants to see an imperative here, i.e. "remove" instead of "removing".

[dscho]

/allow

[gitgitgadget]

User nirmalhk7 is now allowed to use GitGitGadget.

[gitgitgadget]

There is a merge commit in this Pull Request:

0365b9139b1e23e0fbd7d0114e62f373958dae3c

Please rebase the branch and force-push.

[dscho]

Hmm... no regression test added?

[nirmalhk7]

Not quite sure what you mean by regression testing. Do you mean these testing instructions here?

[dscho]

Yes. If you run git grep bisect t/, you will see that we already have plenty of regression tests to prevent regressions in git bisect's functionality.

Your change introduces a change of behavior that needs to be accompanied by more tests.

[nirmalhk7]

I sincerely apologise, but since I have examinations coming up and multiple projects to submit, I will not be able to keep up with Git development and hence will not be able to complete this MR.

I will stick around though: Git surely is a massive and well written project from which I have lots to learn. Thank you @dscho and the Git community for their guidance.