-
Notifications
You must be signed in to change notification settings - Fork 141
ci: build and test with Python 2 and 3; the cheap way #538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
git-p4.py includes support for python3, but this was not previously validated in CI. Lets actually do that. As of writing, python-3.5 has reached end-of-life, but has been updated recently enough that it's reasonable to attemp to support it. We do not have a pressing need for features only available in 3.6 and later. Usage of python3 is limited to the linux-gcc pipeline on Azure. It is assumed that passing both python2 and python3 tests on one platform translates to doing the same on others. Travis-CI is unchanged, as no tests are run in those environments. Signed-off-by: Yang Zhao <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
This reverts commit 6c14d98.
There is an issue in commit a08c429: |
There is an issue in commit 2a569f8: |
@@ -182,6 +185,9 @@ osx-clang|osx-gcc) | |||
if [ "$jobname" = osx-gcc ] | |||
then | |||
export CC=gcc-9 | |||
MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)" | |||
else | |||
MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only objection I have is that it is already pretty magic to anybody who was not involved in the development of our CI/PR pipeline where and how the different axes are tested. This exacerbates that problem... How are people to know that the -gcc
axis is intended to test with Python 3.x whereas the -clang
ones are intended to test with Python 2.x?
bae6976
to
8e1c21c
Compare
9917873
to
166794b
Compare
744843a
to
8326456
Compare
6ef4ed5
to
216d55f
Compare
ef1bc7d
to
ea0cb5c
Compare
4f95ceb
to
c9e4248
Compare
Will it work?