ci: build and test with Python 2 and 3; the cheap way #538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
git-p4.py includes support for python3, but this was not previously validated in CI. Lets actually do that. As of writing, python-3.5 has reached end-of-life, but has been updated recently enough that it's reasonable to attemp to support it. We do not have a pressing need for features only available in 3.6 and later. Usage of python3 is limited to the linux-gcc pipeline on Azure. It is assumed that passing both python2 and python3 tests on one platform translates to doing the same on others. Travis-CI is unchanged, as no tests are run in those environments. Signed-off-by: Yang Zhao <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
This reverts commit 6c14d98.
|
There is an issue in commit a08c429: |
|
There is an issue in commit 2a569f8: |
dscho
approved these changes
Jan 23, 2020
| @@ -182,6 +185,9 @@ osx-clang|osx-gcc) | |||
| if [ "$jobname" = osx-gcc ] | |||
| then | |||
| export CC=gcc-9 | |||
| MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)" | |||
| else | |||
| MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)" | |||
There was a problem hiding this comment.
The only objection I have is that it is already pretty magic to anybody who was not involved in the development of our CI/PR pipeline where and how the different axes are tested. This exacerbates that problem... How are people to know that the -gcc axis is intended to test with Python 3.x whereas the -clang ones are intended to test with Python 2.x?
dscho
force-pushed
the
pu
branch
8 times, most recently
from
bae6976 to
8e1c21c
Compare
dscho
force-pushed
the
pu
branch
5 times, most recently
from
9917873 to
166794b
Compare
dscho
force-pushed
the
pu
branch
8 times, most recently
from
744843a to
8326456
Compare
dscho
force-pushed
the
pu
branch
11 times, most recently
from
6ef4ed5 to
216d55f
Compare
dscho
force-pushed
the
pu
branch
10 times, most recently
from
ef1bc7d to
ea0cb5c
Compare
dscho
force-pushed
the
pu
branch
6 times, most recently
from
4f95ceb to
c9e4248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will it work?