Skip to content

ci: build and test with Python 2 and 3; the cheap way #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

szeder
Copy link

@szeder szeder commented Jan 23, 2020

Will it work?

yangskyboxlabs and others added 3 commits January 15, 2020 12:53
git-p4.py includes support for python3, but this was not previously
validated in CI. Lets actually do that.

As of writing, python-3.5 has reached end-of-life, but has been updated
recently enough that it's reasonable to attemp to support it. We do not
have a pressing need for features only available in 3.6 and later.

Usage of python3 is limited to the linux-gcc pipeline on Azure. It is
assumed that passing both python2 and python3 tests on one platform
translates to doing the same on others.

Travis-CI is unchanged, as no tests are run in those environments.

Signed-off-by: Yang Zhao <[email protected]>
Signed-off-by: Junio C Hamano <[email protected]>
@gitgitgadget
Copy link

gitgitgadget bot commented Jan 23, 2020

There is an issue in commit a08c429:
Commit not signed off

@gitgitgadget
Copy link

gitgitgadget bot commented Jan 23, 2020

There is an issue in commit 2a569f8:
Commit checks stopped - the message is too short

@@ -182,6 +185,9 @@ osx-clang|osx-gcc)
if [ "$jobname" = osx-gcc ]
then
export CC=gcc-9
MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python3)"
else
MAKEFLAGS="$MAKEFLAGS PYTHON_PATH=$(which python2)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only objection I have is that it is already pretty magic to anybody who was not involved in the development of our CI/PR pipeline where and how the different axes are tested. This exacerbates that problem... How are people to know that the -gcc axis is intended to test with Python 3.x whereas the -clang ones are intended to test with Python 2.x?

@dscho dscho force-pushed the pu branch 11 times, most recently from 6ef4ed5 to 216d55f Compare June 2, 2020 21:29
@dscho dscho force-pushed the pu branch 10 times, most recently from ef1bc7d to ea0cb5c Compare June 11, 2020 00:30
@dscho dscho force-pushed the pu branch 6 times, most recently from 4f95ceb to c9e4248 Compare June 19, 2020 06:06
@szeder szeder closed this Jun 21, 2020
@szeder szeder deleted the yz/p4-py3 branch June 21, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants