Skip to content

New Psuh command #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

New Psuh command #381

wants to merge 8 commits into from

Conversation

mirucam
Copy link

@mirucam mirucam commented Oct 9, 2019

MyFirstContribution tutorial:
Added an example command named psuh.

kleinlicht added 7 commits October 9, 2019 09:50
Internal metrics indicate this is a command many users expect to be
present. So here's an implementation to help drive customer
satisfaction and engagement: a pony which doubtfully greets the user,
or, a Pony Saying "Um, Hello" (PSUH).

This commit message is intentionally formatted to 72 columns per line,
starts with a single line as "commit message subject" that is written as
if to command the codebase to do something (add this, teach a command
that). The body of the message is designed to add information about the
commit that is not readily deduced from reading the associated diff,
such as answering the question "why?".

Signed-off-by: mrubioc <[email protected]>
Signed-off-by: kleinlicht <>
Signed-off-by: kleinlicht <>
Signed-off-by: kleinlicht <>
Signed-off-by: kleinlicht <>
Signed-off-by: kleinlicht <>
Signed-off-by: kleinlicht <>
@gitgitgadget
Copy link

gitgitgadget bot commented Oct 9, 2019

Welcome to GitGitGadget

Hi @mirucam, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

Delete extra test t9999-push-tutorial1.sh
@dscho
Copy link
Member

dscho commented Oct 9, 2019

@mirucam you did not mean to submit this, really, were you?

@mirucam mirucam closed this Oct 9, 2019
@mirucam
Copy link
Author

mirucam commented Oct 9, 2019 via email

@dscho
Copy link
Member

dscho commented Oct 10, 2019

I am an Outreachy applicant

Welcome!

I am following the step by step guide: https://git-scm.com/docs/MyFirstContribution that includes sending a PR to GitGitGadget of the example command psuh.

Ah, now I understand! May I offer a couple of suggestions?

  • When opening a GitGitGadget Pull Request, it is a very good idea to describe the motivation in the PR description (which will be sent as a cover letter). In your case, a rather important piece of information that should go into that cover letter is that you are an Outreachy participant 😊
  • The tutorial is not really meant to be followed by the letter, it merely shows you the technical steps how to contribute patches, but you should pick a micro-project that you like (and git psuh is not one of them 😄 )
  • If you have trouble finding a good micro-project, may I suggest this list? https://github.com/gitgitgadget/git/issues?utf8=%E2%9C%93&q=sort%3Aupdated-desc+label%3A%22good+first+issue%22+is%3Aopen+
  • Please do not hesitate to reach out, even in this PR, if you encounter any obstacle you think I could help with.

@mirucam
Copy link
Author

mirucam commented Oct 10, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants