Skip to content

Fallout from azure-pipelines-msvc #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dscho
Copy link
Member

@dscho dscho commented Oct 7, 2019

This is a spill-over from my patch series that introduces support for building Git using Visual Studio in our CI builds, based on a suggestion by Johannes Sixt: complete the symmetry by adding a helper that does the opposite of index_pos_to_insert_pos().

I tried to be super inventive and came up with the name insert_pos_to_index_pos() for said helper.

Cc: Johannes Sixt [email protected]

We have just introduced the helper `index_pos_to_insert_pos()` to help
avoiding underflows when returning `-1 - pos` for cases where we want to
return an insert position, using the ones' complement (as `int`).

As pointed out during the review of the patch series that introduced it,
this helper wants to be accompanied by a helper that reverse that ones'
complement, for clarity. This patch does exactly that.

Signed-off-by: Johannes Schindelin <[email protected]>
@dscho
Copy link
Member Author

dscho commented Oct 8, 2019

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Oct 8, 2019

Submitted as [email protected]

@dscho
Copy link
Member Author

dscho commented Feb 14, 2020

Seems that the goal of this patch won't get any support on the Git mailing list.

@dscho dscho closed this Feb 14, 2020
@dscho dscho deleted the insert-pos-to-index-pos branch February 14, 2020 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant