quote: handle null and empty strings in sq_quote_buf_pretty() #314

garimasi514 · 2019-08-19T17:26:13Z

Hey,

Empty arguments passed on the command line can be a represented by
a '', however sq_quote_buf_pretty was incorrectly dropping these
arguments altogether. Fix this problem by ensuring that such
arguments are emitted as '' instead.

Looking forward to your review.
Cheers!
Garima Singh

Reported by: Junio Hamano [email protected] in
https://public-inbox.org/git/[email protected]/T/#m9e33936067ec2066f675aa63133a2486efd415fd

Cc: [email protected], [email protected], [email protected]

gitgitgadget · 2019-08-19T17:26:58Z

Welcome to GitGitGadget

Hi @garimasi514, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

the lines should not exceed 76 columns,
the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
the commit messages' body should be describing the "why?" of the change.
Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

t/t0091-quote.sh

t/helper/test-quote.c

garimasi514 · 2019-08-20T19:33:38Z

/submit

gitgitgadget · 2019-08-20T19:35:12Z

Submitted as [email protected]

Makefile

quote.c

t/t0014-alias.sh

garimasi514 · 2019-08-26T14:43:59Z

/submit

gitgitgadget · 2019-08-26T14:44:55Z

Submitted as [email protected]

jeffhostetler · 2019-08-26T15:01:10Z

quote.c

+	if (!src) 
+		BUG("BUG can't append a NULL token to the buffer");
+
+	/* In case of empty tokens, add a '' to ensure they 


For a multi-line comment, the style is

/* * start words on line 2 * and not on the line with the slash star. */

gitgitgadget · 2019-08-26T15:25:39Z

quote.c

@@ -48,6 +48,18 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src)
 	static const char ok_punct[] = "+,-./:=@_^";


On the Git mailing list, Garima Singh wrote (reply to this):

Thanks for the review Junio! I really appreciate it and look forward to hear what you think of the updated patch. Cheers! Garima Singh On Mon, Aug 26, 2019 at 10:44 AM Garima Singh via GitGitGadget <[email protected]> wrote: > > From: Garima Singh <[email protected]> > > The sq_quote_buf_pretty() function does not emit anything when > the incoming string is empty, but the function is to accumulate > command line arguments, properly quoted as necessary, and the > right way to add an argument that is an empty string is to show > it quoted, i.e. ''. We warn the caller with the BUG macro if they > pass in a NULL. > > Reported by: Junio Hamano <[email protected]> > Signed-off-by: Garima Singh <[email protected]> > --- > quote.c | 12 ++++++++++++ > t/t0014-alias.sh | 8 ++++++++ > 2 files changed, 20 insertions(+) > > diff --git a/quote.c b/quote.c > index 7f2aa6faa4..6d0f8a22a9 100644 > --- a/quote.c > +++ b/quote.c > @@ -48,6 +48,18 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src) > static const char ok_punct[] = "+,-./:=@_^"; > const char *p; > > + /* In case of null tokens, warn the user of the BUG in their call. */ > + if (!src) > + BUG("BUG can't append a NULL token to the buffer"); > + > + /* In case of empty tokens, add a '' to ensure they > + * don't get inadvertently dropped. > + */ > + if (!*src) { > + strbuf_addstr(dst, "''"); > + return; > + } > + > for (p = src; *p; p++) { > if (!isalpha(*p) && !isdigit(*p) && !strchr(ok_punct, *p)) { > sq_quote_buf(dst, src); > diff --git a/t/t0014-alias.sh b/t/t0014-alias.sh > index a070e645d7..9c176c7cbb 100755 > --- a/t/t0014-alias.sh > +++ b/t/t0014-alias.sh > @@ -37,4 +37,12 @@ test_expect_success 'looping aliases - internal execution' ' > # test_i18ngrep "^fatal: alias loop detected: expansion of" output > #' > > +test_expect_success 'run-command parses empty args properly, using sq_quote_buf_pretty' ' > + cat >expect <<-EOF && > + fatal: cannot change to '\''alias.foo=frotz foo '\'''\'' bar'\'': No such file or directory > + EOF > + test_expect_code 128 git -C "alias.foo=frotz foo '\'''\'' bar" foo 2>actual && > + test_cmp expect actual > +' > + > test_done > -- > gitgitgadget

On the Git mailing list, Junio C Hamano wrote (reply to this):

Garima Singh <[email protected]> writes: >> diff --git a/quote.c b/quote.c >> index 7f2aa6faa4..6d0f8a22a9 100644 >> --- a/quote.c >> +++ b/quote.c >> @@ -48,6 +48,18 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src) >> static const char ok_punct[] = "+,-./:=@_^"; >> const char *p; >> >> + /* In case of null tokens, warn the user of the BUG in their call. */ >> + if (!src) >> + BUG("BUG can't append a NULL token to the buffer"); I thought that the BUG() macro already says "BUG" upfront, no? Dereferencing to see if we have an empty string below will immediately give us segfault, so I would omit this check if I were writing this code, though. >> + /* In case of empty tokens, add a '' to ensure they >> + * don't get inadvertently dropped. >> + */ Our multi-line comments have the opening slash-asterisk and the closing asterisk-slash on their own lines. But more importantly, "In case of empty tokens, add a ''" in this comment has zero information contents---you can read that from the code. Why we do that is what we cannot express in the code, and deserves a comment. /* avoid losing a zero-length string by giving nothing */ or something like that, perhaps? >> + if (!*src) { >> + strbuf_addstr(dst, "''"); >> + return; >> + } >> + >> for (p = src; *p; p++) { >> if (!isalpha(*p) && !isdigit(*p) && !strchr(ok_punct, *p)) { >> sq_quote_buf(dst, src); >> diff --git a/t/t0014-alias.sh b/t/t0014-alias.sh >> index a070e645d7..9c176c7cbb 100755 >> --- a/t/t0014-alias.sh >> +++ b/t/t0014-alias.sh >> @@ -37,4 +37,12 @@ test_expect_success 'looping aliases - internal execution' ' >> # test_i18ngrep "^fatal: alias loop detected: expansion of" output >> #' >> >> +test_expect_success 'run-command parses empty args properly, using sq_quote_buf_pretty' ' >> + cat >expect <<-EOF && >> + fatal: cannot change to '\''alias.foo=frotz foo '\'''\'' bar'\'': No such file or directory >> + EOF >> + test_expect_code 128 git -C "alias.foo=frotz foo '\'''\'' bar" foo 2>actual && >> + test_cmp expect actual >> +' I think it was my mistake, but we do not ahe to use "alias" for something like this, perhaps like: # 'git frotz' will fail with "no such command", but we are # not interested in its exit status. We just want to see # how sq_quote_argv_pretty() shows arguments in the trace. GIT_TRACE=1 git frotz a "" b " " c 2>&1 | sed -ne "/run_command:/s/.*trace: run_command: //p" >actual && echo "git-frotz a '' b ' ' c" >expect && test_cmp expect actual >> + >> test_done >> -- >> gitgitgadget

dscho · 2019-08-28T11:41:17Z

Don't include braces for single-line statements.

Very confusingly, Git no longer insists on the rule to skip braces for single-liners. I don't like them, personally, but you _can_, now. I'd much rather prefer a coding style that can be formatted by a tool, and does not require brain cycles... It is what it is.

garimasi514 · 2019-10-07T16:16:48Z

/submit

gitgitgadget · 2019-10-07T16:18:00Z

Submitted as [email protected]

WARNING: garimasi514 has no public email address set on GitHub

gitgitgadget · 2019-10-07T17:11:40Z

quote.c

@@ -48,6 +48,16 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src)
 	static const char ok_punct[] = "+,-./:=@_^";


On the Git mailing list, Garima Singh wrote (reply to this):

I just noticed the typo in the commit message in my latest update. Sorry about that. Junio, would you be willing to fix it up whenever you queue the patch? Or would you like me to send another update. Thanks Garima G Singh On 10/7/2019 12:17 PM, Garima Singh via GitGitGadget wrote: > From: Garima Singh <[email protected]> > > The sq_quote_buf_pretty() function does not emit anything > when the incoming string is empty, but the function is to > accumulate command line arguments, properly quoted as > necessary, and the right way to add an argument that is an > empty string is to show it quoted, i.e. ''. We warn the caller > with the BUG macro is they pass in a NULL. > > Reported by: Junio Hamano <[email protected]> > Signed-off-by: Garima Singh <[email protected]> > --- > quote.c | 10 ++++++++++ > t/t0014-alias.sh | 7 +++++++ > 2 files changed, 17 insertions(+) > > diff --git a/quote.c b/quote.c > index 7f2aa6faa4..f31ebf6c43 100644 > --- a/quote.c > +++ b/quote.c > @@ -48,6 +48,16 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src) > static const char ok_punct[] = "+,-./:=@_^"; > const char *p; > > + /* In case of null tokens, warn the user of the BUG in their call. */ > + if (!src) > + BUG("Cannot append a NULL token to the buffer"); > + > + /* Avoid dropping a zero-length token by adding '' */ > + if (!*src) { > + strbuf_addstr(dst, "''"); > + return; > + } > + > for (p = src; *p; p++) { > if (!isalpha(*p) && !isdigit(*p) && !strchr(ok_punct, *p)) { > sq_quote_buf(dst, src); > diff --git a/t/t0014-alias.sh b/t/t0014-alias.sh > index a070e645d7..ae316aa6fd 100755 > --- a/t/t0014-alias.sh > +++ b/t/t0014-alias.sh > @@ -37,4 +37,11 @@ test_expect_success 'looping aliases - internal execution' ' > # test_i18ngrep "^fatal: alias loop detected: expansion of" output > #' > > +test_expect_success 'run-command parses empty args properly, using sq_quote_buf_pretty' ' > + GIT_TRACE=1 git frotz a "" b " " c 2>&1 | > + sed -ne "/run_command:/s/.*trace: run_command: //p" >actual && > + echo "git-frotz a '\'''\'' b '\'' '\'' c" >expect && > + test_cmp expect actual > +' > + > test_done >

gitgitgadget · 2019-10-07T17:29:45Z

quote.c

@@ -48,6 +48,16 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src)
 	static const char ok_punct[] = "+,-./:=@_^";


On the Git mailing list, Eric Sunshine wrote (reply to this):

On Mon, Oct 7, 2019 at 12:17 PM Garima Singh via GitGitGadget <[email protected]> wrote: > quote: handle numm and empty strings in sq_quote_buf_pretty What is "numm"? What does it mean to "handle" these things? A possible rewrite of the subject to explain the problem more precisely rather than using generalizations might be: sq_quote_buf_pretty: don't drop empty arguments > The sq_quote_buf_pretty() function does not emit anything > when the incoming string is empty, but the function is to > accumulate command line arguments, properly quoted as > necessary, and the right way to add an argument that is an > empty string is to show it quoted, i.e. ''. We warn the caller > with the BUG macro is they pass in a NULL. s/is they/if they/ By including the final sentence in this paragraph, the reader is confused into thinking that warning the caller with BUG() is the overall purpose of this patch and is the "fix" for the stated problem. At minimum, the final sentence should be yanked out to its own paragraph or, better yet, dropped altogether since it's of little importance in the overall scheme of the patch. As a reader of this commit message, I find it difficult to understand what problem it's trying to solve since the problem and solution and existing behavior are presented in a circuitous way which doesn't make any of them stand out clearly. Here's a possible rewrite: sq_quote_buf_pretty: don't drop empty arguments Empty arguments passed on a command-line should be represented by a zero-length quoted string, however, sq_quote_buf_pretty() incorrectly drops these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. > Reported by: Junio Hamano <[email protected]> > Signed-off-by: Garima Singh <[email protected]> > --- > diff --git a/quote.c b/quote.c > @@ -48,6 +48,16 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src) > + /* In case of null tokens, warn the user of the BUG in their call. */ > + if (!src) > + BUG("Cannot append a NULL token to the buffer"); The comment merely repeats what the code itself already says clearly, thus adds no value and ought to be dropped. Moreover, this entire check seems superfluous since the program will crash anyhow as soon as 'src' is dereferenced (just below), thus the programmer will find out soon enough about the error. I'd suggest dropping this check entirely since it's not adding any value. > + /* Avoid dropping a zero-length token by adding '' */ > + if (!*src) { > + strbuf_addstr(dst, "''"); > + return; > + } Ditto regarding dropping the useless comment which merely repeats what the code itself already says clearly. > diff --git a/t/t0014-alias.sh b/t/t0014-alias.sh > @@ -37,4 +37,11 @@ test_expect_success 'looping aliases - internal execution' ' > +test_expect_success 'run-command parses empty args properly, using sq_quote_buf_pretty' ' Is "parses" the correct word? Should it be "formats" or something? Also, the bit about "using sq_quote_buf_pretty" lets an implementation detail bleed unnecessarily into the test suite, and that detail could become outdated at some point (say, if some function ever replaces that one, for instance). It should be sufficient for the test title merely to mention that it is checking that empty arguments are handled properly. So, perhaps: test_expect_success 'run-command formats empty args properly' ' > + GIT_TRACE=1 git frotz a "" b " " c 2>&1 | > + sed -ne "/run_command:/s/.*trace: run_command: //p" >actual && > + echo "git-frotz a '\'''\'' b '\'' '\'' c" >expect && > + test_cmp expect actual > +'

On the Git mailing list, Garima Singh wrote (reply to this):

On 10/7/2019 1:27 PM, Eric Sunshine wrote: > On Mon, Oct 7, 2019 at 12:17 PM Garima Singh via GitGitGadget > <[email protected]> wrote: >> quote: handle numm and empty strings in sq_quote_buf_pretty > > What is "numm"? Typo. Fixing in next update. > What does it mean to "handle" these things? A possible rewrite of the > subject to explain the problem more precisely rather than using > generalizations might be: > > sq_quote_buf_pretty: don't drop empty arguments > >> The sq_quote_buf_pretty() function does not emit anything >> when the incoming string is empty, but the function is to >> accumulate command line arguments, properly quoted as >> necessary, and the right way to add an argument that is an >> empty string is to show it quoted, i.e. ''. We warn the caller >> with the BUG macro is they pass in a NULL. > > s/is they/if they/ Typo. Fixing in next update. > By including the final sentence in this paragraph, the reader is > confused into thinking that warning the caller with BUG() is the > overall purpose of this patch and is the "fix" for the stated problem. > At minimum, the final sentence should be yanked out to its own > paragraph or, better yet, dropped altogether since it's of little > importance in the overall scheme of the patch. > > As a reader of this commit message, I find it difficult to understand > what problem it's trying to solve since the problem and solution and > existing behavior are presented in a circuitous way which doesn't make > any of them stand out clearly. Here's a possible rewrite: > > sq_quote_buf_pretty: don't drop empty arguments > > Empty arguments passed on a command-line should be represented by > a zero-length quoted string, however, sq_quote_buf_pretty() > incorrectly drops these arguments altogether. Fix this problem by > ensuring that such arguments are emitted as '' instead. Works for me. Thanks! >> Reported by: Junio Hamano <[email protected]> >> Signed-off-by: Garima Singh <[email protected]> >> --- >> diff --git a/quote.c b/quote.c >> @@ -48,6 +48,16 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src) >> + /* In case of null tokens, warn the user of the BUG in their call. */ >> + if (!src) >> + BUG("Cannot append a NULL token to the buffer"); > > The comment merely repeats what the code itself already says clearly, > thus adds no value and ought to be dropped. > > Moreover, this entire check seems superfluous since the program will > crash anyhow as soon as 'src' is dereferenced (just below), thus the > programmer will find out soon enough about the error. I'd suggest > dropping this check entirely since it's not adding any value. > Fair enough. Removing the comment. Leaving the check. I would rather the caller of the function know what went wrong instead of a segfault. >> diff --git a/t/t0014-alias.sh b/t/t0014-alias.sh >> @@ -37,4 +37,11 @@ test_expect_success 'looping aliases - internal execution' ' >> +test_expect_success 'run-command parses empty args properly, using sq_quote_buf_pretty' ' > > Is "parses" the correct word? Should it be "formats" or something? > Sure. > Also, the bit about "using sq_quote_buf_pretty" lets an implementation > detail bleed unnecessarily into the test suite, and that detail could > become outdated at some point (say, if some function ever replaces > that one, for instance). It should be sufficient for the test title > merely to mention that it is checking that empty arguments are handled > properly. So, perhaps: > > test_expect_success 'run-command formats empty args properly' ' > Sure.

garimasi514 · 2019-10-07T19:38:05Z

/submit

gitgitgadget · 2019-10-07T19:39:20Z

Submitted as [email protected]

WARNING: garimasi514 has no public email address set on GitHub

dscho · 2019-10-07T20:32:08Z

/azp run

azure-pipelines · 2019-10-07T20:32:18Z

Azure Pipelines successfully started running 2 pipeline(s).

gitgitgadget · 2019-10-08T03:18:11Z

quote.c

@@ -48,6 +48,15 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src)
 	static const char ok_punct[] = "+,-./:=@_^";


On the Git mailing list, Junio C Hamano wrote (reply to this):

"Garima Singh via GitGitGadget" <[email protected]> writes: > From: Garima Singh <[email protected]> > > Empty arguments passed on the command line can be a represented by > a '', however sq_quote_buf_pretty was incorrectly dropping these > arguments altogether. Fix this problem by ensuring that such > arguments are emitted as '' instead. > > Reported by: Junio Hamano <[email protected]> > Signed-off-by: Garima Singh <[email protected]> > --- > quote.c | 9 +++++++++ > t/t0014-alias.sh | 7 +++++++ > 2 files changed, 16 insertions(+) > > diff --git a/quote.c b/quote.c > index 7f2aa6faa4..26f1848dde 100644 > --- a/quote.c > +++ b/quote.c > @@ -48,6 +48,15 @@ void sq_quote_buf_pretty(struct strbuf *dst, const char *src) > static const char ok_punct[] = "+,-./:=@_^"; > const char *p; > > + if (!src) > + BUG("Cannot append a NULL token to the buffer"); Remove these two lines. I do not want to see "if (!ptr) BUG("don't give a NULL pointer")" sprinkled to every function that takes a pointer that must not be NULL. Any caller that violates the contract with the callee deserves a segfault, so let's leave it at that. > + /* Avoid losing a zero-length string by adding '' */ > + if (!*src) { > + strbuf_addstr(dst, "''"); > + return; > + } > + Nice. > for (p = src; *p; p++) { > if (!isalpha(*p) && !isdigit(*p) && !strchr(ok_punct, *p)) { > sq_quote_buf(dst, src); > diff --git a/t/t0014-alias.sh b/t/t0014-alias.sh > index a070e645d7..2694c81afd 100755 > --- a/t/t0014-alias.sh > +++ b/t/t0014-alias.sh > @@ -37,4 +37,11 @@ test_expect_success 'looping aliases - internal execution' ' > # test_i18ngrep "^fatal: alias loop detected: expansion of" output > #' > > +test_expect_success 'run-command formats empty args properly' ' > + GIT_TRACE=1 git frotz a "" b " " c 2>&1 | > + sed -ne "/run_command:/s/.*trace: run_command: //p" >actual && > + echo "git-frotz a '\'''\'' b '\'' '\'' c" >expect && > + test_cmp expect actual > +' > + > test_done

Empty arguments passed on the command line can be a represented by a '', however sq_quote_buf_pretty was incorrectly dropping these arguments altogether. Fix this problem by ensuring that such arguments are emitted as '' instead. Reported by: Junio Hamano <[email protected]> Signed-off-by: Garima Singh <[email protected]>

garimasi514 · 2019-10-08T16:39:48Z

/submit

gitgitgadget · 2019-10-08T16:40:59Z

Submitted as [email protected]

WARNING: garimasi514 has no public email address set on GitHub

gitgitgadget · 2019-10-09T03:35:02Z

This branch is now known as gs/sq-quote-buf-pretty.

gitgitgadget · 2019-10-09T03:35:04Z

This patch series was integrated into pu via git@6dee36b.

gitgitgadget · 2019-10-09T07:52:26Z

This patch series was integrated into pu via git@df0b039.

gitgitgadget · 2019-10-11T07:44:58Z

This patch series was integrated into pu via git@85ba7b7.

gitgitgadget · 2019-10-11T07:45:00Z

This patch series was integrated into next via git@2f7c006.

gitgitgadget · 2019-10-15T07:25:06Z

This patch series was integrated into pu via git@7745887.

gitgitgadget · 2019-10-15T07:25:08Z

This patch series was integrated into next via git@7745887.

gitgitgadget · 2019-10-15T07:25:09Z

This patch series was integrated into master via git@7745887.

gitgitgadget · 2019-10-15T07:25:11Z

Closed via 7745887.

garimasi514 changed the title ~~Make sure sq_quote_buf_pretty doesn't drop tokens that are empty or n…~~ [WIP] Make sure sq_quote_buf_pretty doesn't drop tokens that are empty or n… Aug 19, 2019

garimasi514 force-pushed the coreGit-fixQuote branch 2 times, most recently from f995ddc to 6392059 Compare August 19, 2019 19:56

garimasi514 changed the title ~~[WIP] Make sure sq_quote_buf_pretty doesn't drop tokens that are empty or n…~~ quote: handle null and empty strings in sq_quote_buf_pretty() Aug 19, 2019

garimasi514 force-pushed the coreGit-fixQuote branch 2 times, most recently from 9a20289 to ca4d4dd Compare August 19, 2019 20:13

garimasi514 commented Aug 20, 2019

View reviewed changes

t/t0091-quote.sh Outdated Show resolved Hide resolved

wilbaker reviewed Aug 20, 2019

View reviewed changes

t/helper/test-quote.c Outdated Show resolved Hide resolved

garimasi514 force-pushed the coreGit-fixQuote branch from ca4d4dd to 9d2685b Compare August 20, 2019 18:56

gitgitgadget bot reviewed Aug 20, 2019

View reviewed changes

Makefile Outdated Show resolved Hide resolved

gitgitgadget bot reviewed Aug 20, 2019

View reviewed changes

Makefile Outdated Show resolved Hide resolved

weekly-digest bot mentioned this pull request Aug 25, 2019

Weekly Digest (18 August, 2019 - 25 August, 2019) #321

Closed

garimasi514 commented Aug 26, 2019

View reviewed changes

quote.c Show resolved Hide resolved

garimasi514 force-pushed the coreGit-fixQuote branch from 9d2685b to 0f2152e Compare August 26, 2019 13:34

derrickstolee reviewed Aug 26, 2019

View reviewed changes

quote.c Outdated Show resolved Hide resolved

garimasi514 commented Aug 26, 2019

View reviewed changes

quote.c Outdated Show resolved Hide resolved

derrickstolee reviewed Aug 26, 2019

View reviewed changes

t/t0014-alias.sh Outdated Show resolved Hide resolved

garimasi514 force-pushed the coreGit-fixQuote branch 2 times, most recently from 655c001 to b9a6859 Compare August 26, 2019 13:54

jeffhostetler reviewed Aug 26, 2019

View reviewed changes

gitgitgadget bot reviewed Aug 26, 2019

View reviewed changes

weekly-digest bot mentioned this pull request Sep 1, 2019

Weekly Digest (25 August, 2019 - 1 September, 2019) #326

Closed

garimasi514 force-pushed the coreGit-fixQuote branch from b9a6859 to 399fe02 Compare October 7, 2019 16:12

gitgitgadget bot reviewed Oct 7, 2019

View reviewed changes

garimasi514 force-pushed the coreGit-fixQuote branch 2 times, most recently from b89f6a4 to a6a0217 Compare October 7, 2019 17:59

gitgitgadget bot reviewed Oct 8, 2019

View reviewed changes

garimasi514 force-pushed the coreGit-fixQuote branch from a6a0217 to b33a402 Compare October 8, 2019 14:46

garimasi514 force-pushed the coreGit-fixQuote branch from b33a402 to 412626c Compare October 8, 2019 14:47

gitgitgadget bot added the pu label Oct 9, 2019

gitgitgadget bot added the next label Oct 11, 2019

weekly-digest bot mentioned this pull request Oct 13, 2019

Weekly Digest (6 October, 2019 - 13 October, 2019) #393

Closed

gitgitgadget bot added the master label Oct 15, 2019

gitgitgadget bot closed this Oct 15, 2019

garimasi514 deleted the coreGit-fixQuote branch December 11, 2019 20:49

		@@ -48,6 +48,18 @@ void sq_quote_buf_pretty(struct strbuf dst, const char src)
		static const char ok_punct[] = "+,-./:=@_^";

		@@ -48,6 +48,16 @@ void sq_quote_buf_pretty(struct strbuf dst, const char src)
		static const char ok_punct[] = "+,-./:=@_^";

		@@ -48,6 +48,15 @@ void sq_quote_buf_pretty(struct strbuf dst, const char src)
		static const char ok_punct[] = "+,-./:=@_^";

quote: handle null and empty strings in sq_quote_buf_pretty() #314

quote: handle null and empty strings in sq_quote_buf_pretty() #314

Uh oh!

Conversation

garimasi514 commented Aug 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitgitgadget bot commented Aug 19, 2019

Welcome to GitGitGadget

Contributing the patches

Uh oh!

Uh oh!

Uh oh!

garimasi514 commented Aug 20, 2019

Uh oh!

gitgitgadget bot commented Aug 20, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

garimasi514 commented Aug 26, 2019

Uh oh!

gitgitgadget bot commented Aug 26, 2019

Uh oh!

jeffhostetler Aug 26, 2019

Choose a reason for hiding this comment

Uh oh!

gitgitgadget bot Aug 26, 2019

Choose a reason for hiding this comment

Uh oh!

gitgitgadget bot Aug 26, 2019

Choose a reason for hiding this comment

Uh oh!

dscho commented Aug 28, 2019 via email

Uh oh!

garimasi514 commented Oct 7, 2019

Uh oh!

gitgitgadget bot commented Oct 7, 2019

Uh oh!

gitgitgadget bot Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

gitgitgadget bot Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

gitgitgadget bot Oct 7, 2019

Choose a reason for hiding this comment

Uh oh!

garimasi514 commented Oct 7, 2019

Uh oh!

gitgitgadget bot commented Oct 7, 2019

Uh oh!

dscho commented Oct 7, 2019

Uh oh!

azure-pipelines bot commented Oct 7, 2019

Uh oh!

gitgitgadget bot Oct 8, 2019

Choose a reason for hiding this comment

Uh oh!

garimasi514 commented Oct 8, 2019

Uh oh!

gitgitgadget bot commented Oct 8, 2019

Uh oh!

gitgitgadget bot commented Oct 9, 2019

Uh oh!

gitgitgadget bot commented Oct 9, 2019

Uh oh!

gitgitgadget bot commented Oct 9, 2019

Uh oh!

gitgitgadget bot commented Oct 11, 2019

Uh oh!

gitgitgadget bot commented Oct 11, 2019

Uh oh!

gitgitgadget bot commented Oct 15, 2019

Uh oh!

gitgitgadget bot commented Oct 15, 2019

Uh oh!

garimasi514 commented Aug 19, 2019 •

edited

Loading