git-p4: auto-delete named temporary file #303

philip-mcgraw · 2019-08-01T15:37:49Z

Take new approach using the NamedTemporaryFile()
file-like object as input to the ZipFile() which
auto-deletes after implicit close leaving with scope.

Original code produced double-open problems on Windows
platform from using already open NamedTemporaryFile()
generated filename instead of object.

Thanks to Andrey for patiently suggesting several
iterations on this change for avoiding exceptions!

Also print error details after resulting IOError to make
debugging cause of exception less mysterious when it has
nothing to do with "git version recent enough."

Signed-off-by: Philip.McGraw [email protected]

philip-mcgraw · 2019-08-01T21:38:24Z

/submit

gitgitgadget · 2019-08-01T21:39:21Z

Submitted as [email protected]

dscho · 2019-08-01T22:41:57Z

Please do use the GitHub feature where you update PRs by force-pushing the PR branch instead of renaming the branches. Git is really good at versioning, file/branch names are not.

gitgitgadget · 2019-08-02T03:54:52Z

On the Git mailing list, Andrey wrote (reply to this):



01.08.2019, 17:39, "Philip McGraw via GitGitGadget" <[email protected]>:
> Take new approach using the NamedTemporaryFile() file-like object as input
> to the ZipFile() which auto-deletes after implicit close leaving with scope.
>
> Original code produced double-open problems on Windows platform from using
> already open NamedTemporaryFile() generated filename instead of object.
>
> Thanks to Andrey for patiently suggesting several iterations on this change
> for avoiding exceptions!
>
> Also print error details after resulting IOError to make debugging cause of
> exception less mysterious when it has nothing to do with "git version recent
> enough."
>
> Signed-off-by: Philip.McGraw [email protected]
> [[email protected]]
>
> Philip.McGraw (1):
>   git-p4: auto-delete named temporary file
>
>  git-p4.py | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
>
> base-commit: 1feeaaf26bff51996f9f96c6dc41ca0f95ab5fc4
> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-303%2Fphilip-mcgraw%2Fgit-p4-auto-delete-named-temporary-file-v3-v1
> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-303/philip-mcgraw/git-p4-auto-delete-named-temporary-file-v3-v1
> Pull-Request: https://github.com/gitgitgadget/git/pull/303
> --
> gitgitgadget

Looks good to me!
Reviewed-by: Andrey Mazo <[email protected]>


-- 
Andrey.

Avoid double-open exceptions on Windows platform when calculating for lfs compressed size threshold (git-p4.largeFileCompressedThreshold) comparisons. Take new approach using the NamedTemporaryFile() file-like object as input to the ZipFile() which auto-deletes after implicit close leaving with scope. Original code had double-open exception on Windows platform because file still open from NamedTemporaryFile() using generated filename instead of object. Thanks to Andrey for patiently suggesting several iterations on this change for avoiding exceptions! Also print error details after resulting IOError to make debugging cause of exception less mysterious when it has nothing to do with "git version recent enough." Signed-off-by: Philip.McGraw <[email protected]> Reviewed-by: Andrey Mazo <[email protected]>

philip-mcgraw · 2019-08-02T19:34:55Z

Please do use the GitHub feature where you update PRs by force-pushing the PR branch instead of renaming the branches. Git is really good at versioning, file/branch names are not.

Thanks; sorry for the confusion over branch renaming.

philip-mcgraw · 2019-08-02T19:42:51Z

/submit

gitgitgadget · 2019-08-02T19:43:48Z

Submitted as [email protected]

ahippo · 2019-08-21T01:21:00Z

I wonder why the actual patch didn't make it to the mailing list -- only the cover letter did.
I reviewed it here with no problems, but Junio may not pick it up from here.

@dscho, do you have any ideas?

philip-mcgraw · 2019-08-21T14:08:42Z

I wonder why the actual patch didn't make it to the mailing list -- only the cover letter did.
I reviewed it here with no problems, but Junio may not pick it up from here.

@dscho, do you have any ideas?

I wondered what else to do to get the patch included. Without the patch, everyone using git-p4 with LFS on Windows would get double-open exceptions.

dscho · 2019-08-21T18:08:42Z

According to git shortlog -nse --since=2.years.ago git-p4.py, our resident git-p4 expert is Luke Diamand [email protected]. Maybe reply to the thread, Cc:ing Luke, requesting a review?

philip-mcgraw · 2019-08-21T18:32:30Z

Sent: Wednesday, 21 August, 2019 14:09 To: Philip McGraw ***@***.***> Cc: Philip McGraw ***@***.***>; Author ***@***.***> Subject: Re: [gitgitgadget/git] git-p4: auto-delete named temporary file (#303) According to git shortlog -nse --since=2.years.ago git-p4.py, our resident git-p4 expert is Luke Diamand ***@***.*** Maybe reply to the thread, Cc:ing Luke, requesting a review?

Thanks Johannes! Luke, would you be able to review this patch? #303 Thanks! Philip

ahippo · 2019-08-23T03:09:20Z

Junio may pick up the patch even without Luke's review.
I was just worried that the patch itself didn't make it to the list for some reason (GitGitGadget bug?).
(and wasn't mentioned in the recent "What's cooking" email)

dscho · 2019-08-23T13:17:54Z

Luke, would you be able to review this patch?

By "reply" I meant on the mailing list ;-)

I was just worried that the patch itself didn't make it to the list for some reason (GitGitGadget bug?).

It made it to the list: https://public-inbox.org/git/[email protected]/#r

If you follow the advice on the bottom of that page, you can reply to the mails themselves, Cc:ing Luke. That should get their attention.

ahippo · 2019-08-23T13:25:54Z

I was just worried that the patch itself didn't make it to the list for some reason (GitGitGadget bug?).

It made it to the list: https://public-inbox.org/git/[email protected]/#r

Only the cover letter made it, but not the actual patch, right?
This is what I was talking about.

dscho · 2019-08-26T13:29:23Z

Only the cover letter made it, but not the actual patch, right?

Yes :-( I don't know, why, though.

dscho · 2019-08-26T13:52:32Z

I tried to re-send it, and it kinda worked, but it used a different Message-Id... sigh

gitgitgadget · 2019-08-26T13:55:32Z

On the Git mailing list, Git Gadget wrote (reply to this):

From: "Philip.McGraw" <[email protected]>

Take new approach using the NamedTemporaryFile()
file-like object as input to the ZipFile() which
auto-deletes after implicit close leaving with scope.

Original code produced double-open problems on Windows
platform from using already open NamedTemporaryFile()
generated filename instead of object.

Thanks to Andrey for patiently suggesting several
iterations on this change for avoiding exceptions!

Also print error details after resulting IOError to make
debugging cause of exception less mysterious when it has
nothing to do with "git version recent enough."

Signed-off-by: Philip.McGraw <[email protected]>
---
 git-p4.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/git-p4.py b/git-p4.py
index c71a6832e2..33bdb14fd1 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1160,13 +1160,11 @@ def exceedsLargeFileThreshold(self, relPath, contents):
             if contentsSize <=
gitConfigInt('git-p4.largeFileCompressedThreshold'):
                 return False
             contentTempFile = self.generateTempFile(contents)
-            compressedContentFile =
tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=False)
-            zf = zipfile.ZipFile(compressedContentFile.name, mode='w')
-            zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
-            zf.close()
-            compressedContentsSize = zf.infolist()[0].compress_size
+            compressedContentFile =
tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=True)
+            with zipfile.ZipFile(compressedContentFile, mode='w') as zf:
+                zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
+                compressedContentsSize = zf.infolist()[0].compress_size
             os.remove(contentTempFile)
-            os.remove(compressedContentFile.name)
             if compressedContentsSize >
gitConfigInt('git-p4.largeFileCompressedThreshold'):
                 return True
         return False
@@ -3514,8 +3512,9 @@ def importHeadRevision(self, revision):
         self.updateOptionDict(details)
         try:
             self.commit(details,
self.extractFilesFromCommit(details), self.branch)
-        except IOError:
+        except IOError as err:
             print("IO error with git fast-import. Is your git version
recent enough?")
+            print("IO error details: {}".format(err))
             print(self.gitError.read())

     def openStreams(self):

--
gitgitgadget

gitgitgadget · 2019-08-26T16:40:47Z

On the Git mailing list, Junio C Hamano wrote (reply to this):

Funny that the patch is line-wrapped, which I do not recall ever
seeing in GGG-generated e-mails.  Dscho, do you know if anything
funny is going on?

Git Gadget <[email protected]> writes:

> From: "Philip.McGraw" <[email protected]>
> ...
> diff --git a/git-p4.py b/git-p4.py
> index c71a6832e2..33bdb14fd1 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -1160,13 +1160,11 @@ def exceedsLargeFileThreshold(self, relPath, contents):
>              if contentsSize <=
> gitConfigInt('git-p4.largeFileCompressedThreshold'):
>                  return False
>              contentTempFile = self.generateTempFile(contents)
> -            compressedContentFile =
> tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=False)
> -            zf = zipfile.ZipFile(compressedContentFile.name, mode='w')
> -            zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
> ...

ahippo · 2019-08-27T03:00:34Z

I tried to re-send it, and it kinda worked, but it used a different Message-Id... sigh

@dscho, thank you!
However, I'm not sure if you resent the latest patch.
The change itself looks proper, but the commit message is not the latest, and doesn't have my Reviewed-by.

I guess, I'll just resend @philip-mcgraw's change using send-email.

gitgitgadget · 2019-08-27T03:47:53Z

On the Git mailing list, Andrey Mazo wrote (reply to this):

From: "Philip.McGraw" <[email protected]>

Avoid double-open exceptions on Windows platform when
calculating for lfs compressed size threshold
(git-p4.largeFileCompressedThreshold) comparisons.

Take new approach using the NamedTemporaryFile()
file-like object as input to the ZipFile() which
auto-deletes after implicit close leaving with scope.

Original code had double-open exception on Windows
platform because file still open from NamedTemporaryFile()
using generated filename instead of object.

Thanks to Andrey for patiently suggesting several
iterations on this change for avoiding exceptions!

Also print error details after resulting IOError to make
debugging cause of exception less mysterious when it has
nothing to do with "git version recent enough."

Signed-off-by: Philip.McGraw <[email protected]>
Reviewed-by: Andrey Mazo <[email protected]>
---
 git-p4.py | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/git-p4.py b/git-p4.py
index c71a6832e2..33bdb14fd1 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -1158,17 +1158,15 @@ def exceedsLargeFileThreshold(self, relPath, contents):
         if gitConfigInt('git-p4.largeFileCompressedThreshold'):
             contentsSize = sum(len(d) for d in contents)
             if contentsSize <= gitConfigInt('git-p4.largeFileCompressedThreshold'):
                 return False
             contentTempFile = self.generateTempFile(contents)
-            compressedContentFile = tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=False)
-            zf = zipfile.ZipFile(compressedContentFile.name, mode='w')
-            zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
-            zf.close()
-            compressedContentsSize = zf.infolist()[0].compress_size
+            compressedContentFile = tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=True)
+            with zipfile.ZipFile(compressedContentFile, mode='w') as zf:
+                zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
+                compressedContentsSize = zf.infolist()[0].compress_size
             os.remove(contentTempFile)
-            os.remove(compressedContentFile.name)
             if compressedContentsSize > gitConfigInt('git-p4.largeFileCompressedThreshold'):
                 return True
         return False
 
     def addLargeFile(self, relPath):
@@ -3512,12 +3510,13 @@ def importHeadRevision(self, revision):
         details["time"] = res["time"]
 
         self.updateOptionDict(details)
         try:
             self.commit(details, self.extractFilesFromCommit(details), self.branch)
-        except IOError:
+        except IOError as err:
             print("IO error with git fast-import. Is your git version recent enough?")
+            print("IO error details: {}".format(err))
             print(self.gitError.read())
 
     def openStreams(self):
         self.importProcess = subprocess.Popen(["git", "fast-import"],
                                               stdin=subprocess.PIPE,

base-commit: 1feeaaf26bff51996f9f96c6dc41ca0f95ab5fc4
Pull-Request: https://github.com/gitgitgadget/git/pull/303
-- 
2.21.0

gitgitgadget · 2019-08-27T22:36:59Z

On the Git mailing list, Junio C Hamano wrote (reply to this):

Andrey Mazo <[email protected]> writes:

> From: "Philip.McGraw" <[email protected]>
>
> Avoid double-open exceptions on Windows platform when
> calculating for lfs compressed size threshold
> (git-p4.largeFileCompressedThreshold) comparisons.
>
> Take new approach using the NamedTemporaryFile()
> file-like object as input to the ZipFile() which
> auto-deletes after implicit close leaving with scope.
>
> Original code had double-open exception on Windows
> platform because file still open from NamedTemporaryFile()
> using generated filename instead of object.
>
> Thanks to Andrey for patiently suggesting several
> iterations on this change for avoiding exceptions!
>
> Also print error details after resulting IOError to make
> debugging cause of exception less mysterious when it has
> nothing to do with "git version recent enough."
>
> Signed-off-by: Philip.McGraw <[email protected]>
> Reviewed-by: Andrey Mazo <[email protected]>
> ---

Luke, does this look good?

I know Mazo is the only other contributor who has multiple commits
to git-p4.py in the past 2 years, to make Reviewed-by carry some
weight ;-) but as we have so small number of people touching this
script anyway, I'd rather see what the main contributor in the past
2 years thinks.

Thanks.

>  git-p4.py | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/git-p4.py b/git-p4.py
> index c71a6832e2..33bdb14fd1 100755
> --- a/git-p4.py
> +++ b/git-p4.py
> @@ -1158,17 +1158,15 @@ def exceedsLargeFileThreshold(self, relPath, contents):
>          if gitConfigInt('git-p4.largeFileCompressedThreshold'):
>              contentsSize = sum(len(d) for d in contents)
>              if contentsSize <= gitConfigInt('git-p4.largeFileCompressedThreshold'):
>                  return False
>              contentTempFile = self.generateTempFile(contents)
> -            compressedContentFile = tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=False)
> -            zf = zipfile.ZipFile(compressedContentFile.name, mode='w')
> -            zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
> -            zf.close()
> -            compressedContentsSize = zf.infolist()[0].compress_size
> +            compressedContentFile = tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=True)
> +            with zipfile.ZipFile(compressedContentFile, mode='w') as zf:
> +                zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
> +                compressedContentsSize = zf.infolist()[0].compress_size
>              os.remove(contentTempFile)
> -            os.remove(compressedContentFile.name)
>              if compressedContentsSize > gitConfigInt('git-p4.largeFileCompressedThreshold'):
>                  return True
>          return False
>  
>      def addLargeFile(self, relPath):
> @@ -3512,12 +3510,13 @@ def importHeadRevision(self, revision):
>          details["time"] = res["time"]
>  
>          self.updateOptionDict(details)
>          try:
>              self.commit(details, self.extractFilesFromCommit(details), self.branch)
> -        except IOError:
> +        except IOError as err:
>              print("IO error with git fast-import. Is your git version recent enough?")
> +            print("IO error details: {}".format(err))
>              print(self.gitError.read())
>  
>      def openStreams(self):
>          self.importProcess = subprocess.Popen(["git", "fast-import"],
>                                                stdin=subprocess.PIPE,
>
> base-commit: 1feeaaf26bff51996f9f96c6dc41ca0f95ab5fc4
> Pull-Request: https://github.com/gitgitgadget/git/pull/303

gitgitgadget · 2019-08-28T08:40:11Z

On the Git mailing list, Luke Diamand wrote (reply to this):

On Tue, 27 Aug 2019 at 23:31, Junio C Hamano <[email protected]> wrote:
>
> Andrey Mazo <[email protected]> writes:
>
> > From: "Philip.McGraw" <[email protected]>
> >
> > Avoid double-open exceptions on Windows platform when
> > calculating for lfs compressed size threshold
> > (git-p4.largeFileCompressedThreshold) comparisons.
> >
> > Take new approach using the NamedTemporaryFile()
> > file-like object as input to the ZipFile() which
> > auto-deletes after implicit close leaving with scope.
> >
> > Original code had double-open exception on Windows
> > platform because file still open from NamedTemporaryFile()
> > using generated filename instead of object.
> >
> > Thanks to Andrey for patiently suggesting several
> > iterations on this change for avoiding exceptions!
> >
> > Also print error details after resulting IOError to make
> > debugging cause of exception less mysterious when it has
> > nothing to do with "git version recent enough."
> >
> > Signed-off-by: Philip.McGraw <[email protected]>
> > Reviewed-by: Andrey Mazo <[email protected]>
> > ---
>
> Luke, does this look good?
>
> I know Mazo is the only other contributor who has multiple commits
> to git-p4.py in the past 2 years, to make Reviewed-by carry some
> weight ;-) but as we have so small number of people touching this
> script anyway, I'd rather see what the main contributor in the past
> 2 years thinks.

I think it looks reasonable.

Ack.


>
> Thanks.
>
> >  git-p4.py | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
> >
> > diff --git a/git-p4.py b/git-p4.py
> > index c71a6832e2..33bdb14fd1 100755
> > --- a/git-p4.py
> > +++ b/git-p4.py
> > @@ -1158,17 +1158,15 @@ def exceedsLargeFileThreshold(self, relPath, contents):
> >          if gitConfigInt('git-p4.largeFileCompressedThreshold'):
> >              contentsSize = sum(len(d) for d in contents)
> >              if contentsSize <= gitConfigInt('git-p4.largeFileCompressedThreshold'):
> >                  return False
> >              contentTempFile = self.generateTempFile(contents)
> > -            compressedContentFile = tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=False)
> > -            zf = zipfile.ZipFile(compressedContentFile.name, mode='w')
> > -            zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
> > -            zf.close()
> > -            compressedContentsSize = zf.infolist()[0].compress_size
> > +            compressedContentFile = tempfile.NamedTemporaryFile(prefix='git-p4-large-file', delete=True)
> > +            with zipfile.ZipFile(compressedContentFile, mode='w') as zf:
> > +                zf.write(contentTempFile, compress_type=zipfile.ZIP_DEFLATED)
> > +                compressedContentsSize = zf.infolist()[0].compress_size
> >              os.remove(contentTempFile)
> > -            os.remove(compressedContentFile.name)
> >              if compressedContentsSize > gitConfigInt('git-p4.largeFileCompressedThreshold'):
> >                  return True
> >          return False
> >
> >      def addLargeFile(self, relPath):
> > @@ -3512,12 +3510,13 @@ def importHeadRevision(self, revision):
> >          details["time"] = res["time"]
> >
> >          self.updateOptionDict(details)
> >          try:
> >              self.commit(details, self.extractFilesFromCommit(details), self.branch)
> > -        except IOError:
> > +        except IOError as err:
> >              print("IO error with git fast-import. Is your git version recent enough?")
> > +            print("IO error details: {}".format(err))
> >              print(self.gitError.read())
> >
> >      def openStreams(self):
> >          self.importProcess = subprocess.Popen(["git", "fast-import"],
> >                                                stdin=subprocess.PIPE,
> >
> > base-commit: 1feeaaf26bff51996f9f96c6dc41ca0f95ab5fc4
> > Pull-Request: https://github.com/gitgitgadget/git/pull/303

gitgitgadget · 2019-08-28T12:32:21Z

On the Git mailing list, Johannes Schindelin wrote (reply to this):

Hi Junio,

On Mon, 26 Aug 2019, Junio C Hamano wrote:

> Funny that the patch is line-wrapped, which I do not recall ever
> seeing in GGG-generated e-mails.  Dscho, do you know if anything
> funny is going on?

Yes, this was me trying to re-send the patch via GMail's web UI because
the first time GitGitGadget sent it, it did not get through (only the
cover letter did).

So I tried to fix the screw-up by sending manually, and screwed it up
even more.

Sorry about that.
Dscho

>
> Git Gadget <[email protected]> writes:
>
> > From: "Philip.McGraw" <[email protected]>
> > ...
> > diff --git a/git-p4.py b/git-p4.py
> > index c71a6832e2..33bdb14fd1 100755
> > --- a/git-p4.py
> > +++ b/git-p4.py
> > @@ -1160,13 +1160,11 @@ def exceedsLargeFileThreshold(self, relPath, c=
ontents):
> >              if contentsSize <=3D
> > gitConfigInt('git-p4.largeFileCompressedThreshold'):
> >                  return False
> >              contentTempFile =3D self.generateTempFile(contents)
> > -            compressedContentFile =3D
> > tempfile.NamedTemporaryFile(prefix=3D'git-p4-large-file', delete=3DFal=
se)
> > -            zf =3D zipfile.ZipFile(compressedContentFile.name, mode=
=3D'w')
> > -            zf.write(contentTempFile, compress_type=3Dzipfile.ZIP_DEF=
LATED)
> > ...
>

gitgitgadget · 2019-08-29T03:59:08Z

On the Git mailing list, Junio C Hamano wrote (reply to this):

Johannes Schindelin <[email protected]> writes:

> Yes, this was me trying to re-send the patch via GMail's web UI because
> the first time GitGitGadget sent it, it did not get through (only the
> cover letter did).

As long as that was manual screw-up, while fixing some glitches in
the machinery, that is fine.  I care about automation running
smoothly.

Thanks.

gitgitgadget · 2019-08-29T11:50:16Z

On the Git mailing list, Johannes Schindelin wrote (reply to this):

Hi Junio,

On Wed, 28 Aug 2019, Junio C Hamano wrote:

> Johannes Schindelin <[email protected]> writes:
>
> > Yes, this was me trying to re-send the patch via GMail's web UI becaus=
e
> > the first time GitGitGadget sent it, it did not get through (only the
> > cover letter did).
>
> As long as that was manual screw-up, while fixing some glitches in
> the machinery, that is fine.  I care about automation running
> smoothly.

Indeed, I also care about automation, as that keeps me sane (I would not
be able to do everything I do without offloading substantial parts to
Azure Pipelines, like GitGitGadget).

I am quite a bit worried about this, as it seemed to happen at least
three times. I'll see if it happens again, and when it does, I will try
to save the mbox files as build artifacts, and then add another job that
I can run manually to re-send the mbox files that did not make it to the
mailing list (identified by the absence from public-inbox).

At the moment, I am still rather busy elsewhere, trying to catch up
after three weeks that I spent (or tried to spend) mostly offline.

And I am really sorry for not writing a reply to the thread when I tried
to re-send the patch manually, describing what I was doing, and why. I
will try to do better next time!

Ciao,
Dscho

gitgitgadget · 2019-10-06T02:47:01Z

On the Git mailing list, Junio C Hamano wrote (reply to this):

> >> ...
> >>  Luke, does this look good?
> >>
> >>  I know Mazo is the only other contributor who has multiple commits
> >>  to git-p4.py in the past 2 years, to make Reviewed-by carry some
> >>  weight ;-) but as we have so small number of people touching this
> >>  script anyway, I'd rather see what the main contributor in the past
> >>  2 years thinks.
> >
> > I think it looks reasonable.
> >
> > Ack.
>
> Junio, does Philip need to resend a v3 with Luke's ack or will you just add it yourself while queuing the patch?
> (sorry, if you already picked up the patch -- I just didn't see it in the last What's cooking update)

Sorry, I do not recall the details of this old a thread but if I
recall correctly there was only a corrupt patch that I cannot use,
so somebody would need to send a patch that actually applies. With a
patch that applies, I can tweak the log message
with acked-by etc. just fine.

Thanks.

gitgitgadget · 2019-10-06T12:00:54Z

This branch is now known as pm/p4-auto-delete-named-temporary.

gitgitgadget · 2019-10-06T12:00:55Z

This patch series was integrated into pu via git@3ec4a7a.

gitgitgadget · 2019-10-07T03:47:36Z

This patch series was integrated into pu via git@9edfe2c.

gitgitgadget · 2019-10-07T03:47:38Z

This patch series was integrated into next via git@4f45be7.

gitgitgadget · 2019-10-08T05:08:44Z

This patch series was integrated into pu via git@9c7ca4a.

gitgitgadget · 2019-10-09T03:34:56Z

This patch series was integrated into pu via git@328caa9.

gitgitgadget · 2019-10-09T07:52:15Z

This patch series was integrated into pu via git@2e956f7.

gitgitgadget · 2019-10-09T07:52:16Z

This patch series was integrated into next via git@2e956f7.

gitgitgadget · 2019-10-09T07:52:17Z

This patch series was integrated into master via git@2e956f7.

gitgitgadget · 2019-10-09T07:52:20Z

Closed via 2e956f7.

philip-mcgraw force-pushed the git-p4-auto-delete-named-temporary-file-v3 branch from 1b270ef to 7e59b5c Compare August 2, 2019 14:08

weekly-digest bot mentioned this pull request Aug 25, 2019

Weekly Digest (18 August, 2019 - 25 August, 2019) #321

Closed

weekly-digest bot mentioned this pull request Sep 1, 2019

Weekly Digest (25 August, 2019 - 1 September, 2019) #326

Closed

gitgitgadget bot added the pu label Oct 6, 2019

gitgitgadget bot added the next label Oct 7, 2019

gitgitgadget bot added the master label Oct 9, 2019

gitgitgadget bot closed this Oct 9, 2019

git-p4: auto-delete named temporary file #303

git-p4: auto-delete named temporary file #303

Uh oh!

Conversation

philip-mcgraw commented Aug 1, 2019

Uh oh!

philip-mcgraw commented Aug 1, 2019

Uh oh!

gitgitgadget bot commented Aug 1, 2019

Uh oh!

dscho commented Aug 1, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gitgitgadget bot commented Aug 2, 2019

Uh oh!

philip-mcgraw commented Aug 2, 2019

Uh oh!

philip-mcgraw commented Aug 2, 2019

Uh oh!

gitgitgadget bot commented Aug 2, 2019

Uh oh!

ahippo commented Aug 21, 2019

Uh oh!

philip-mcgraw commented Aug 21, 2019

Uh oh!

dscho commented Aug 21, 2019

Uh oh!

philip-mcgraw commented Aug 21, 2019 via email

Uh oh!

ahippo commented Aug 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dscho commented Aug 23, 2019

Uh oh!

ahippo commented Aug 23, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dscho commented Aug 26, 2019

Uh oh!

dscho commented Aug 26, 2019

Uh oh!

gitgitgadget bot commented Aug 26, 2019

Uh oh!

gitgitgadget bot commented Aug 26, 2019

Uh oh!

ahippo commented Aug 27, 2019

Uh oh!

gitgitgadget bot commented Aug 27, 2019

Uh oh!

gitgitgadget bot commented Aug 27, 2019

Uh oh!

gitgitgadget bot commented Aug 28, 2019

Uh oh!

gitgitgadget bot commented Aug 28, 2019

Uh oh!

gitgitgadget bot commented Aug 29, 2019

Uh oh!

gitgitgadget bot commented Aug 29, 2019

Uh oh!

gitgitgadget bot commented Oct 6, 2019

Uh oh!

gitgitgadget bot commented Oct 6, 2019

Uh oh!

gitgitgadget bot commented Oct 6, 2019

Uh oh!

gitgitgadget bot commented Oct 7, 2019

Uh oh!

gitgitgadget bot commented Oct 7, 2019

Uh oh!

gitgitgadget bot commented Oct 8, 2019

Uh oh!

gitgitgadget bot commented Oct 9, 2019

Uh oh!

gitgitgadget bot commented Oct 9, 2019

Uh oh!

gitgitgadget bot commented Oct 9, 2019

Uh oh!

gitgitgadget bot commented Oct 9, 2019

Uh oh!

gitgitgadget bot commented Oct 9, 2019

dscho commented Aug 1, 2019 •

edited

Loading

ahippo commented Aug 23, 2019 •

edited

Loading

ahippo commented Aug 23, 2019 •

edited

Loading