Skip to content

l10n: de.po: Fix German translation #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

l10n: de.po: Fix German translation #278

wants to merge 1 commit into from

Conversation

derphilipp
Copy link

Fix translation error of "complete => "vollständig" instead of "unvollständig"

Currently: Documentation states that --unshallow can NOT be used on INcomplete projects. This is wrong;
Correct would be: --unshallow can NOT be used on complete projects.

This change fixes that error in the German translation.

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 28, 2019

Welcome to GitGitGadget

Hi @derphilipp, and welcome to GitGitGadget, the GitHub App to send patch series to the Git mailing list from GitHub Pull Requests.

Please make sure that this Pull Request has a good description, as it will be used as cover letter.

Also, it is a good idea to review the commit messages one last time, as the Git project expects them in a quite specific form:

  • the lines should not exceed 76 columns,
  • the first line should be like a header and typically start with a prefix like "tests:" or "commit:", and
  • the commit messages' body should be describing the "why?" of the change.
  • Finally, the commit messages should end in a Signed-off-by: line matching the commits' author.

It is in general a good idea to await the automated test ("Checks") in this Pull Request before contributing the patches, e.g. to avoid trivial issues such as unportable code.

Contributing the patches

Before you can contribute the patches, your GitHub username needs to be added to the list of permitted users. Any already-permitted user can do that, by adding a PR comment of the form /allow <username>.

Once on the list of permitted usernames, you can contribute the patches to the Git mailing list by adding a PR comment /submit.

After you submit, GitGitGadget will respond with another comment that contains the link to the cover letter mail in the Git mailing list archive. Please make sure to monitor the discussion in that thread and to address comments and suggestions.

If you do not want to subscribe to the Git mailing list just to be able to respond to a mail, you can download the mbox ("raw") file corresponding to the mail you want to reply to from the Git mailing list. If you use GMail, you can upload that raw mbox file via:

curl -g --user "<EMailAddress>:<Password>" --url "imaps://imap.gmail.com/INBOX" -T /path/to/raw.txt

Fix translation error of "complete" => "vollständig" instead of
"unvollständig"

Signed-off-by: Philipp Weißmann <[email protected]>
@derphilipp
Copy link
Author

/submit

@gitgitgadget
Copy link

gitgitgadget bot commented Jun 28, 2019

Error: User derphilipp is not permitted to use GitGitGadget

@rimrul
Copy link

rimrul commented Jun 28, 2019

The change is correct, but you could re-submit this pr to ruester/git-po-de
(the german l10n coordinators l10n repo).

@derphilipp
Copy link
Author

I created a pull-request: ruester#2

Thank you!

@dscho
Copy link
Member

dscho commented Jun 28, 2019

I created a pull-request: ruester#2

Perfect! Thank you so much.

@dscho dscho closed this Jun 28, 2019
derphilipp added a commit to derphilipp/git-po that referenced this pull request Jun 28, 2019
Fix translation error of "complete => "vollständig"
instead of "unvollständig"

Currently: Documentation states that --unshallow
can NOT be used on INcomplete projects.

This is wrong;
Correct would be: --unshallow can NOT
be used on complete projects.

This change fixes that error in the German translation.

See also: gitgitgadget#278

Signed-off-by: Philipp Weißmann <[email protected]>
@derphilipp
Copy link
Author

Was asked to open it up on https://github.com/git-l10n/git-po , which resultet in git-l10n#380

@rimrul
Copy link

rimrul commented Jun 28, 2019

Sorry for the big roundtrip from git/git to gitgitgadget/git to ruester/git-po-de to git-l10n/git-po. I'd have sent you to git-l10n/git-po directly, but IMO po/README indicates that these contributions should be collected in the repositories of the laguage teams before being collectively submitted to the central l10n repository.

@derphilipp
Copy link
Author

No problem, as long as the change/fix gets through in the end, my job is done 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants