blame: read diff config #270
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When users use custom diff settings in their Git config, they expect all diff algorithms to use those values. In particular, some diffs change greatly if the "patience" algorithm is used instead of the default. In cases where the diff config changes the diff output, the output of 'git blame' can also change. This alters the user's expectations, as they look at the diff for that commit and cannot understand how the line was changed by that commit. Read the diff config options in 'git blame' so the diff algorithm uses these options. Signed-off-by: Derrick Stolee <[email protected]>
|
This doesn't work at all. |
I am curious: why? Is it because |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a support email where a user could not make sense of some blame output and the diff they saw when looking at the commit. When I saw the commit, the diff looked like the file was completely rewritten. However, with the "--patience" option, the output looked much cleaner and clearly that line was not modified by that commit.
I could not find a way to modify the diff algorithm used by 'git blame' using config options or command-line arguments, so I thought it would be worth reading the diff config settings in the blame builtin. If we want to start taking command-line options, then that could be handled by a later series.