Skip to content

When skipping test cases in the test suite, skip lazy prereqs and &&-chain validation, too #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dscho opened this issue Sep 24, 2019 · 3 comments
Labels
good first issue Good for newcomers

Comments

@dscho
Copy link
Member

dscho commented Sep 24, 2019

The evaluation of the lazy prereq is apparently evaluated even for test cases that are skipped explicitly via the --run option or via GIT_SKIP_TESTS.

Also, the &&-chain validation seems to run no matter what.

Both should be skipped when the test case is known to be skipped already.

@dscho dscho added the good first issue Good for newcomers label Sep 24, 2019
@dscho
Copy link
Member Author

dscho commented Sep 25, 2019

Another issue with the lazy prereqs is that they mishandle the -x option: while the trace is enabled during the lazy evaluation, it is then turned off for the actual test case.

@sunshineco
Copy link

Also, the &&-chain validation seems to run no matter what.

I took a look at this while answering a question about this issue on the Git mailing list, and I see no evidence — either by direct inspection or by instrumenting the code — that &&-chain validation is taking place for tests which are being skipped.

@dscho
Copy link
Member Author

dscho commented Aug 25, 2020

Also, the &&-chain validation seems to run no matter what.

I took a look at this while answering a question about this issue on the Git mailing list, and I see no evidence — either by direct inspection or by instrumenting the code — that &&-chain validation is taking place for tests which are being skipped.

I thought I had tested this... Thanks for double-checking!

As to skipping lazy prereqs, I think this has been addressed already, as of e031669

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants