shallow.c: don't free unallocated slabs

auselen · gitster · commit ddb3c856f32f · 2019-10-02T15:03:47.000+09:00
Fix possible segfault when cloning a submodule shallow.

Signed-off-by: Ali Utku Selen &lt;auselen@gmail.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/shallow.c b/shallow.c
@@ -148,6 +148,8 @@ struct commit_list *get_shallow_commits(struct object_array *heads, int depth,
 	for (i = 0; i < depths.slab_count; i++) {
 		int j;
 
+		if (!depths.slab[i])
+			continue;
 		for (j = 0; j < depths.slab_size; j++)
 			free(depths.slab[i][j]);
 	}

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,8 @@ struct commit_list get_shallow_commits(struct object_array heads, int depth,`
`148`	`148`	`for (i = 0; i < depths.slab_count; i++) {`
`149`	`149`	`int j;`
`150`	`150`
	`151`	`+ if (!depths.slab[i])`
	`152`	`+ continue;`
`151`	`153`	`for (j = 0; j < depths.slab_size; j++)`
`152`	`154`	`free(depths.slab[i][j]);`
`153`	`155`	`}`