Skip to content

Commit ac093d5

Browse files
peffgitster
authored andcommitted
t5703: use test_commit_bulk
There are two loops that create 33 commits each using test_commit. Using test_commit_bulk speeds this up from: Benchmark #1: ./t5703-upload-pack-ref-in-want.sh --root=/var/ram/git-tests Time (mean ± σ): 2.142 s ± 0.161 s [User: 1.136 s, System: 0.974 s] Range (min … max): 1.903 s … 2.401 s 10 runs to: Benchmark #1: ./t5703-upload-pack-ref-in-want.sh --root=/var/ram/git-tests Time (mean ± σ): 1.440 s ± 0.114 s [User: 737.7 ms, System: 615.4 ms] Range (min … max): 1.230 s … 1.604 s 10 runs for an average savings of almost 33%. Signed-off-by: Jeff King <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent 9516345 commit ac093d5

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t5703-upload-pack-ref-in-want.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ test_expect_success 'setup repos for change-while-negotiating test' '
176176
git clone "http://127.0.0.1:$LIB_HTTPD_PORT/smart/repo" "$LOCAL_PRISTINE" &&
177177
cd "$LOCAL_PRISTINE" &&
178178
git checkout -b side &&
179-
for i in $(test_seq 1 33); do test_commit s$i; done &&
179+
test_commit_bulk --id=s 33 &&
180180
181181
# Add novel commits to upstream
182182
git checkout master &&
@@ -287,7 +287,7 @@ test_expect_success 'setup repos for fetching with ref-in-want tests' '
287287
git clone "file://$REPO" "$LOCAL_PRISTINE" &&
288288
cd "$LOCAL_PRISTINE" &&
289289
git checkout -b side &&
290-
for i in $(test_seq 1 33); do test_commit s$i; done &&
290+
test_commit_bulk --id=s 33 &&
291291
292292
# Add novel commits to upstream
293293
git checkout master &&

0 commit comments

Comments
 (0)