Skip to content

Commit 13ca8fb

Browse files
ruudagitster
authored andcommitted
t5150: skip request-pull test if Perl is disabled
The git-request-pull.sh script invokes Perl, so it requires Perl to be available, but the associated test t5150 does not skip itself when Perl has been disabled, which then makes subtest 4 through 10 fail. Subtest 3 still passes, but for the wrong reasons (it expects git-request-pull to fail, and it does fail when Perl is not available). The initial two subtests that do pass are only doing setup. To prevent t5150 from failing the build when NO_PERL=1, add a check that sets skip_all when "! test_have_prereq PERL", just like how for example t3701-add-interactive skips itself when Perl has been disabled. Signed-off-by: Ruud van Asseldonk <[email protected]> Reviewed-by: Jonathan Nieder <[email protected]> Signed-off-by: Junio C Hamano <[email protected]>
1 parent d9f6f3b commit 13ca8fb

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

t/t5150-request-pull.sh

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,12 @@ test_description='Test workflows involving pull request.'
44

55
. ./test-lib.sh
66

7+
if ! test_have_prereq PERL
8+
then
9+
skip_all='skipping request-pull tests, perl not available'
10+
test_done
11+
fi
12+
713
test_expect_success 'setup' '
814
915
git init --bare upstream.git &&

0 commit comments

Comments
 (0)