Skip to content

Missing spacing in output #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
epage opened this issue Mar 17, 2022 Discussed in #205 · 1 comment · Fixed by #207
Closed

Missing spacing in output #206

epage opened this issue Mar 17, 2022 Discussed in #205 · 1 comment · Fixed by #207
Labels
bug Not as expected

Comments

@epage
Copy link
Collaborator

epage commented Mar 17, 2022

Discussed in #205

Originally posted by arxanas March 16, 2022
Observe this output:

$ git stack
master cleanup(bug_report): add a comment about explicit listing of fields
├─┐
│ ⌽ no-dedup (pushed) feat(move): add `--no-deduplicate-commits` option
├─┐
│ ⌽ d5736d7 temp: work on moving individual commits
│ ⌽ move-individual-commits (pushed) temp: more move individual commits
├─┐
│ ⌽ 29e0946 build: remove dependency on `git-revset`
│ ⌽ a85da5f build: run `cargo upgrade`
│ ⌽ dependabot (pushed) build: add `dependabot.yml`
⌽ 62128e9 fix(effects): fix for often-updated nested operations
⌽ 315d64b fix(rewrite): use existing progress reporting
⌽ progress (pushed) effects: strip ANSI codes from sub-operation output

I think there should be an extra semi-blank line for the last branch, like this:

[tw-mbp-wkhan git-branchless (master)]% git stack
master cleanup(bug_report): add a comment about explicit listing of fields
├─┐
│ ⌽ no-dedup (pushed) feat(move): add `--no-deduplicate-commits` option
├─┐
│ ⌽ d5736d7 temp: work on moving individual commits
│ ⌽ move-individual-commits (pushed) temp: more move individual commits
├─┐
│ ⌽ 29e0946 build: remove dependency on `git-revset`
│ ⌽ a85da5f build: run `cargo upgrade`
│ ⌽ dependabot (pushed) build: add `dependabot.yml`
│
⌽ 62128e9 fix(effects): fix for often-updated nested operations
⌽ 315d64b fix(rewrite): use existing progress reporting
⌽ progress (pushed) effects: strip ANSI codes from sub-operation output

Otherwise, all but the last branch have a contentless line preceding them.

@epage epage added the bug Not as expected label Mar 17, 2022
epage added a commit to epage/git-stack that referenced this issue Mar 17, 2022
@epage
Copy link
Collaborator Author

epage commented Mar 17, 2022

v0.7.1 is now released with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Not as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant