Add RSS feed and news archive #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I stole some bits from http://jekyllrb.com/news/ and managed to get some sort of feed going on. * README on how to get the site running locally (for Ubuntu) * The rev_news/rev_news.html now iterates over all _posts entries * The old Rev News meta content is at the bottom of the page * The feed is available on /feed.xml * I broke the URL to the first edition (will need a redirect) * Single posts is not clickable yet (works on jekyll's site tho) * Still are some copy/paste bits left from the Jekyll news * The nav menu now has two "ghost" entries
Fix the following: - Preserve the old url for the 1st edition (redirects to new permalink scheme) - Use a layout that actually exists - Correct date - Use category news instead of community. I would remove category alltogether, but that provokes an empty span tag to appear in the rendered html.
Remove the redirect-from as it is a bit of an ugly pattern that generates empty bullet points in the navmenu as it is now. Instead of redirecting the old url /rev_news/edition-1.html to go to the first post on /rev_news/2015/03/25/edition-1/ - simply recreate the edition-1.html page as a copy of the first post. Ugly duplication, but it's the simplest solution without having webserver-level rewrite capability. Ref discussion in git#30.
|
@tfnico from looking at the commits, it looks great to me! |
chriscool
added a commit
that referenced
this pull request
Apr 3, 2015
Add RSS feed and news archive
|
Ok I checked and it looks really great! So it is merged now! |
|
@chriscool thanks for reviewing/merging! |
wking
added a commit
to wking/dotfiles-public
that referenced
this pull request
Apr 24, 2015
Now that they have an RSS feed [1]. [1]: git/git.github.io#38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby request to merge the commits discussed in #30, as I think they're good to go live.
cc @chriscool for review/merge.