rn20: Changing the default for "core.abbrev"? #195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add discussion about changing the default abbrev length and dealing with abbreviated SHA-1s.
|
Great, thanks @jnareb ! |
chriscool
reviewed
Oct 19, 2016
| Linus Torvalds asked for increasing the default value for number of | ||
| characters in SHA-1 abbreviations. The `default_abbrev = 7` was | ||
| reasonable at early days of Git, but the project of size of the | ||
| Linux kernel needs `git config --global core.abbrev 12`; while Git |
There was a problem hiding this comment.
I would say "a project of the size of the Linux Kernel" instead but I am not a native speaker so I might be wrong.
There was a problem hiding this comment.
Also I wonder if the semicolon could be replaced by a full stop.
There was a problem hiding this comment.
Yes using "a" here is correct (and probably s/at early days/in the early days/).
I also agree that a period is preferable to a semi-colon here.
There was a problem hiding this comment.
Thanks @peff ! I will make those changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add discussion about changing the default abbrev length and dealing with abbreviated SHA-1s.
I'm not sure if I put it in the correct place; though as it is in 'next' now, perhaps "Reviews" and not "General" subsection of "Discussions" is a good choice. Note also that URLs to commits might need cleanups.
Should I have added a byline?