Skip to content

Make alternates work on UNC paths #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 6, 2015

Conversation

dscho
Copy link
Member

@dscho dscho commented Aug 31, 2015

It has been reported that git.exe won't be able to access alternates when they are specified as UNC paths. Let's make that work.

@dscho dscho self-assigned this Aug 19, 2015
@dscho
Copy link
Member Author

dscho commented Aug 28, 2015

Note: we probably want some special treatment for UNC alternates because just looking up loose objects (which aren't there if there are only packs) would kill us, round-trip-wise. Come to think of it: maybe there is a general improvement lurking here: we can easily determine whether there are any loose objects at that alternate at all, and set a flag skipping loose object lookup later on if there aren't any.

@dscho
Copy link
Member Author

dscho commented Aug 28, 2015

So many distractions today. I'll continue work on this on Monday.

@dscho
Copy link
Member Author

dscho commented Aug 31, 2015

Turned into a Pull Request.

Just like we support having alternates pointing to different drives, we
want to support alternates pointing to network shares, i.e. UNC paths.

Technically, what we do in this patch is not to support UNC alternates,
but to support UNC paths when normalizing paths. But the latter implies
the former, and the former really was the motivation for this patch.

Signed-off-by: Johannes Schindelin <[email protected]>
dscho added a commit that referenced this pull request Sep 6, 2015
Make alternates work on UNC paths
@dscho dscho merged commit a6803cd into git-for-windows:master Sep 6, 2015
@dscho dscho deleted the unc-alternates branch September 6, 2015 16:03
dscho added a commit that referenced this pull request Sep 10, 2015
Make alternates work on UNC paths
dscho added a commit that referenced this pull request Sep 18, 2015
Make alternates work on UNC paths
dscho added a commit that referenced this pull request Sep 29, 2015
Make alternates work on UNC paths
dscho added a commit that referenced this pull request Oct 5, 2015
Make alternates work on UNC paths
dscho added a commit that referenced this pull request Oct 19, 2015
Make alternates work on UNC paths
dscho added a commit that referenced this pull request Nov 9, 2015
Make alternates work on UNC paths
dscho added a commit that referenced this pull request Dec 11, 2015
Make alternates work on UNC paths
dscho added a commit that referenced this pull request Jan 5, 2016
Make alternates work on UNC paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant