Skip to content

Fix linkage on MinGW #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

orgads
Copy link

@orgads orgads commented Feb 28, 2019

fscache is using NtQueryDirectoryFile, but the required library (ntoskrnl) was not linked against.

This amends commit 27a0a6f.

fscache is using NtQueryDirectoryFile, but the required library
was not linked against.

This amends commit 27a0a6f.

Signed-off-by: Orgad Shaneh <[email protected]>
@orgads
Copy link
Author

orgads commented Feb 28, 2019

Any idea why you didn't hit this problem and I did? I have the most up-to-date packages from GfW repo, and building inside mingw64 environment using just make.

@orgads
Copy link
Author

orgads commented Mar 1, 2019

Apparently caused by #2081

@orgads orgads closed this Mar 1, 2019
@orgads orgads deleted the fscache-link branch March 1, 2019 06:56
@dscho
Copy link
Member

dscho commented Mar 1, 2019

Apparently caused by #2081

Hmm. I don't quite understand what the MSYS2 runtime has to do with the MINGW64 linking...

@orgads
Copy link
Author

orgads commented Mar 1, 2019

uname is called in config.mak.uname, and because it returns wrong values, then the platform is mis-detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants