Git binaries on Windows don't have a version number

[JJClements]

Bit of a strange one, we've noticed that the git binaries on Windows don't seem to have a build version (at all) that presumably matches the release version of the application? Is there a reason for this? It's the only one of many applications that we use that doesn't seem to add the tags to the binaries when they are compiled for some reason?

This would also really help with our patching/maintenance to ensure the application is always kept up to date ;-)

Thanks

[shiftkey]

@JJClements not sure I understand the context - the version you get from git version is tagged in the repository and can be tracked to releases:

Is there more that you're looking for from this?

[JJClements]

Hi @shiftkey - I should have been clearer, the (file version AND the product version) properties that you see when you right click on the actual windows binary itself do not match those of the installer.

The installer version (which is correct):

The actual git.exe binary:

[JJClements]

So there are 2 issues, the first is that the format of the file version and the product version differ between the installer and the actual git.exe binary.

The second is that the version of the installer does not match the version of the git.exe binary that is installed on the filesystem.

[dscho]

@JJClements good find.

Now for the next step: figure out how to fix this. A quick web search found this for you: https://stackoverflow.com/questions/6498750/how-do-i-automatically-set-the-version-of-my-inno-setup-installer-according-to-m#6498791

The next steps for you involve:

1. installing the Git for Windows SDK,
2. building an installer with sdk build git-and-installer just to see that everything works
3. patching /usr/src/build-extra/installer/install.iss and/or /usr/src/build-extra/installer/release.sh accordingly
4. verify with sdk build git-and-installer that it worked
5. commit, fork build-extra, push your branch and open a PR.

[r1walz]

@dscho : This is not resolved as of v2.20.1. I'd like to work on this one!

[dscho]

@r1walz go for it!

(It is not resolved as of v2.20.1, and if we can get it solved for v2.21.0, that'd be awesome, especially since the OP clad themselves in silence ever since asked to do something ;-))

[dscho]

@JJClements feel free to pick up work on this, as @r1walz seems to be busy applying for the Google Summer of Code, and it really is not his responsibility to fulfill your wishes, especially when you have been given all the tools to fulfill your wishes yourself.

[dscho]

@r1walz sorry, I did not mean to take this project from you! It also does not exactly look like @JJClements is super eager to help Git for Windows in any way, either, so...

You mentioned on IRC that you have some preliminary patch that however does not seem to do the job? Can you push this somewhere so I can have a look?

[r1walz]

@dscho It's not much I just changed this line, just like you suggested, but, after reading the Inno Setup Script docs, I think that line actually changes the version of the installer, not the installed file. Also, I think we have to change flags in file-list.iss.

[dscho]

@r1walz still, if you can commit a WIP ("Work In Progress") and push it somewhere so I can easily just pull and check things out...

[dscho]

@JJClements a suggestion: buy @r1walz a drink of his choice, as he fulfilled your wish.