Ctrl+C no longer kills running process in Git Bash

[adamvoss]

• I was not able to find an open or closed issue matching what I'm seeing

There are older issues about Ctrl + c but this is specifically about a regression in behavior from 1.15.1.2 (confirmed by downgrading) to 1.16.1.

Setup

• Which version of Git for Windows are you using? Is it 32-bit or 64-bit?

$ git --version --build-options

git version 2.15.1.windows.2
built from commit: 5d5baf91824ec7750b103c8b7c4827ffac202feb
sizeof-long: 4
machine: x86_64

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

$ cmd.exe /c ver
Microsoft Windows [Version 10.0.15063]

# (Windows 10 64-bit)

• What options did you set as part of the installation? Or did you choose the
  defaults?

# One of the following:
> type "C:\Program Files\Git\etc\install-options.txt"
> type "C:\Program Files (x86)\Git\etc\install-options.txt"
> type "%USERPROFILE%\AppData\Local\Programs\Git\etc\install-options.txt"
$ cat /etc/install-options.txt

Editor Option: VIM
Path Option: Cmd
SSH Option: OpenSSH
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: MinTTY
Performance Tweaks FSCache: Enabled
Use Credential Manager: Enabled
Enable Symlinks: Enabled

• Any other interesting things about your environment that might be related
  to the issue you're seeing?

I don't believe so

Details

• Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Git Bash

• What commands did you run to trigger this issue? If you can provide a
  Minimal, Complete, and Verifiable example
  this will help us understand the issue.

git clone https://github.com/rimerosolutions/maven-wrapper-example
cd maven-wrapper-example
./mvnw
*press crtl+c*

• What did you expect to occur after running these commands?

The ./mvnw command to be aborted

• What actually happened instead?

The ./mvnw command continued until it stops for unrelated reasons

A machine-local Maven install presents the same issue, I don't have a lot of other long-running commands to test with.

[dscho]

Hmm. We recently did change the way Ctrl+C works in Git Bash (MinTTY), to resemble more closely what happens in Git Bash (CMD). That should have made it more robust, though, not less robust.

[adamvoss]

Would it be helpful if I tested both version with Git Bash (CMD) installs as well?

[dscho]

@adamvoss it certainly would not hurt, but in general, the Ctrl+C handling is so different between MinTTY and a CMD window that I would always expect the latter to work, without even hitting the code paths we patched in the past few years to address Ctrl+C issues.

[dscho]

@adamvoss could you try running winpty ./mvnw?

(I do not really want to install Java just to test this, let alone risk Maven downloading half the internet, in that sense this MCVE is not really "minimal" for me ;-))

[adamvoss]

winpty does does not work with the Maven wrapper:

$ winpty ./mvnw
winpty: error: cannot start 'C:/Users/user/dev/maven-wrapper-example/mvnw': %1 is not a valid Win32 application. (error 0xc1)

For reasons I don't understand, winpty can't start Maven:

$ winpty mvn
winpty: error: cannot start 'mvn': Not found in PATH

even though it does exist on the path:

$ winpty which mvn
/c/Users/user/AppData/Roaming/maven/apache-maven-3.5.2/bin/mvn

circumventing the path lookup does not help:

$ winpty $(which mvn)
winpty: error: cannot start 'C:/Users/user/AppData/Roaming/maven/apache-maven-3.5.2/bin/mvn': %1 is not a valid Win32 application. (error 0xc1)

mvn is a shell script. If I directly execute the command its execs to do the work, Ctrl + C works:

/c/Program Files/Java/jdk1.7.0_80/bin/java -Djansi.passthrough=true -classpath /c/Users/user/AppData/Roaming/maven/apache-maven-3.5.2/boot/plexus-classworlds-2.5.2.jar -Dclassworlds.conf=/c/Users/user/AppData/Roaming/maven/apache-maven-3.5.2/bin/m2.conf -Dmaven.home=/c/Users/user/AppData/Roaming/maven/apache-maven-3.5.2 -Dlibrary.jansi.path=/c/Users/user/AppData/Roaming/maven/apache-maven-3.5.2/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/c/Users/user/dev/maven-wrapper-example org.codehaus.plexus.classworlds.launcher.Launcher clean compile

^ Ctrl+C works fine

[dscho]

Is mvnw a shell script? Or a .bat/.cmd file?

[adamvoss]

mvnw is a shell script.

[dscho]

mvnw is a shell script.

Okay, then...

$ winpty ./mvnw
winpty: error: cannot start 'C:/Users/user/dev/maven-wrapper-example/mvnw': %1 is not a valid Win32 application. (error 0xc1)

probably means that you have to use winpty sh "$(which mvnw)" instead...

[Thex-PiedDroit]

Hi, sorry to interrupt!
I have this same issue, but i'm kind of new to all things git and console, so i followed the discussion until you started talking about winpty, which i don't really understand what it is.

Anyways, from what i gathered, i understand that changing the way Ctrl+C is handled couldn't hurt, however i would like to know if you (or anyone, really) could tell of an alternative hotkey or workaround to do what Ctrl+C used to, please?
I personally mainly used it to cancel stuff like pulls and pushes, or simply close gitk/gui without having to find the window, so i don't really need anything rough like kill command with pid and all

[adamvoss]

winpty sh "$(which mvn)"

Works. However, it is near unusable because all the color control characters are not interpreted so I get a bunch of extra control characters like in [?[1;31mERROR?[m].

[dscho]

@adamvoss yet another question: if you run plain mvn, does it use java.exe or javaw.exe to run?

(I am trying to get to the point where I understand which Win32 Console is used by mvn, and whether it may be different from the Win32 Console used by the Java process, which would explain things.)

[adamvoss]

It uses java.exe.

I also confirmed by watching in task manager when I called mvn and double checked $(which java):

$ echo $(which java)
/c/Program Files/Java/jdk1.8.0_152/bin/java

[dscho]

Ah, but you talked about mvnw earlier, right? Is there a difference with regards to Ctrl+C whether you call mvn or mvnw?

[adamvoss]

Nope, same problem with both. I only used mvnw to start with to give an example that did not require having Maven installed.

[dscho]

One more tack: if you choose the ConHost option for Git Bash (as opposed to MinTTY) -- you can simulate that by installing a portable Git (that won't interfere with your current installation), deleting usr\bin\mintty.exe and then running git-bash.exe -- does it work? Ctrl+C and coloring?