Skip to content

Commit da7cf2c

Browse files
kbleesdscho
authored andcommitted
Win32: implement basic symlink() functionality (file symlinks only)
Implement symlink() that always creates file symlinks. Fails with ENOSYS if symlinks are disabled or unsupported. Note: CreateSymbolicLinkW() was introduced with symlink support in Windows Vista. For compatibility with Windows XP, we need to load it dynamically and fail gracefully if it isnt's available. Signed-off-by: Karsten Blees <[email protected]>
1 parent cf13693 commit da7cf2c

File tree

2 files changed

+29
-2
lines changed

2 files changed

+29
-2
lines changed

compat/mingw.c

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2906,6 +2906,34 @@ int link(const char *oldpath, const char *newpath)
29062906
return 0;
29072907
}
29082908

2909+
int symlink(const char *target, const char *link)
2910+
{
2911+
wchar_t wtarget[MAX_LONG_PATH], wlink[MAX_LONG_PATH];
2912+
int len;
2913+
2914+
/* fail if symlinks are disabled or API is not supported (WinXP) */
2915+
if (!has_symlinks) {
2916+
errno = ENOSYS;
2917+
return -1;
2918+
}
2919+
2920+
if ((len = xutftowcs_long_path(wtarget, target)) < 0
2921+
|| xutftowcs_long_path(wlink, link) < 0)
2922+
return -1;
2923+
2924+
/* convert target dir separators to backslashes */
2925+
while (len--)
2926+
if (wtarget[len] == '/')
2927+
wtarget[len] = '\\';
2928+
2929+
/* create file symlink */
2930+
if (!CreateSymbolicLinkW(wlink, wtarget, 0)) {
2931+
errno = err_win_to_posix(GetLastError());
2932+
return -1;
2933+
}
2934+
return 0;
2935+
}
2936+
29092937
#ifndef _WINNT_H
29102938
/*
29112939
* The REPARSE_DATA_BUFFER structure is defined in the Windows DDK (in

compat/mingw.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,6 @@ struct utsname {
125125
* trivial stubs
126126
*/
127127

128-
static inline int symlink(const char *oldpath UNUSED, const char *newpath UNUSED)
129-
{ errno = ENOSYS; return -1; }
130128
static inline int fchmod(int fildes UNUSED, mode_t mode UNUSED)
131129
{ errno = ENOSYS; return -1; }
132130
#ifndef __MINGW64_VERSION_MAJOR
@@ -220,6 +218,7 @@ int setitimer(int type, struct itimerval *in, struct itimerval *out);
220218
int sigaction(int sig, struct sigaction *in, struct sigaction *out);
221219
int link(const char *oldpath, const char *newpath);
222220
int uname(struct utsname *buf);
221+
int symlink(const char *target, const char *link);
223222
int readlink(const char *path, char *buf, size_t bufsiz);
224223

225224
/*

0 commit comments

Comments
 (0)