Git GUI: fix Repository>Explore Working Copy (#4357)

dscho · Git for Windows Build Agent · commit 907fd6fea5a7 · 2025-07-01T11:41:48.000Z
This is a companion PR of prati0100/git-gui#95 Since Git v2.39.1, we are a bit more stringent in searching the PATH. In particular, we specifically require the `.exe` suffix. However, the `Repository>Explore Working Copy` command asks for `explorer.exe` to be found on the `PATH`, which _already_ has that suffix. Let's unstartle the PATH-finding logic about this scenario. This fixes #4356
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
@@ -101,6 +101,9 @@ proc _which {what args} {
 
 	if {[is_Windows] && [lsearch -exact $args -script] >= 0} {
 		set suffix {}
+	} elseif {[string match *$_search_exe $what]} {
+		# The search string already has the file extension
+		set suffix {}
 	} else {
 		set suffix $_search_exe
 	}

Original file line number	Diff line number	Diff line change
`@@ -101,6 +101,9 @@ proc _which {what args} {`
`101`	`101`
`102`	`102`	`if {[is_Windows] && [lsearch -exact $args -script] >= 0} {`
`103`	`103`	`set suffix {}`
	`104`	`+ } elseif {[string match *$_search_exe $what]} {`
	`105`	`+ # The search string already has the file extension`
	`106`	`+ set suffix {}`
`104`	`107`	`} else {`
`105`	`108`	`set suffix $_search_exe`
`106`	`109`	`}`