Skip to content

Commit 8cfd03a

Browse files
committed
mingw: demonstrate a problem with certain absolute paths
On Windows, there are several categories of absolute paths. One such category starts with a backslash and is implicitly relative to the drive associated with the current working directory. Example: c: git clone https://github.com/git-for-windows/git \G4W should clone into C:\G4W. There is currently a problem with that, in that mingw_mktemp() does not expect the _wmktemp() function to prefix the absolute path with the drive prefix, and as a consequence, the resulting path does not fit into the originally-passed string buffer. The symptom is a "Result too large" error. Reported by Juan Carlos Arevalo Baeza. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 9028643 commit 8cfd03a

File tree

1 file changed

+14
-5
lines changed

1 file changed

+14
-5
lines changed

t/t5580-unc-paths.sh

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,30 @@ fi
2020
UNCPATH="$(winpwd)"
2121
case "$UNCPATH" in
2222
[A-Z]:*)
23+
WITHOUTDRIVE="${UNCPATH#?:}"
2324
# Use administrative share e.g. \\localhost\C$\git-sdk-64\usr\src\git
2425
# (we use forward slashes here because MSYS2 and Git accept them, and
2526
# they are easier on the eyes)
26-
UNCPATH="//localhost/${UNCPATH%%:*}\$/${UNCPATH#?:}"
27-
test -d "$UNCPATH" || {
28-
skip_all='could not access administrative share; skipping'
29-
test_done
30-
}
27+
UNCPATH="//localhost/${UNCPATH%%:*}\$$WITHOUTDRIVE"
3128
;;
3229
*)
3330
skip_all='skipping UNC path tests, cannot determine current path as UNC'
3431
test_done
3532
;;
3633
esac
3734

35+
test_expect_failure 'clone into absolute path lacking a drive prefix' '
36+
USINGBACKSLASHES="$(echo "$WITHOUTDRIVE"/without-drive-prefix |
37+
tr / \\\\)" &&
38+
git clone . "$USINGBACKSLASHES" &&
39+
test -f without-drive-prefix/.git/HEAD
40+
'
41+
42+
test -d "$UNCPATH" || {
43+
skip_all='could not access administrative share; skipping'
44+
test_done
45+
}
46+
3847
test_expect_success setup '
3948
test_commit initial
4049
'

0 commit comments

Comments
 (0)