Reduce MinGit's size a little #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In msys2/MSYS2-packages@325eedfc14 (a rather monster-type of a huge change), the build-time dependency `tcl` was upgraded to a full-scale runtime dependency of all SQLite packages, including `libsqlite`. This is most likely a bug (which was easy to miss, given the amount of changes accumulated in that big patch), as `tcl` is still marked as a runtime dependency of the `tcl-sqlite` package (which is still correct). But `tcl` is not required to use `libsqlite`, which `openssh` does, and therefore we now have this useless baggage we have to shlep around. Let's exclude it manually. Noticed in git-for-windows/git#1439 (comment) Signed-off-by: Johannes Schindelin <[email protected]>
|
There are three parts in package |
Good point! |
The BusyBox-variant of MinGit ships with `cmp` and `diff` by virtue of being BusyBox applets. Besides, `cmp.exe` and friends were not working anyway because of missing msys-iconv-2.dll and msys-intl-8.dll. Signed-off-by: Johannes Schindelin <[email protected]>
Signed-off-by: Johannes Schindelin <[email protected]>
This requires git-for-windows/MINGW-packages#52 to work, and reduces the `.zip` file by about one megabyte (`git-remote-http.exe` weighs two megabytes that compress by about 50% in a `.zip` file). Signed-off-by: Johannes Schindelin <[email protected]>
Some programs, such as OpenSSH, require the environment variable `SHELL` to contain an absolute path to an executable. No extra arguments allowed. However, BusyBox' `ash` would need to be called like this: <mingit>\mingw64\bin\busybox.exe sh [...] If the `sh` is omitted, only mayhem will ensue. To allow for setting `SHELL` in such a manner, we taught the good ole' Git wrapper to stand in. That is, if the Git wrapper detects that it is run with the base name `ash.exe` (or `sh.exe`), it will try to spawn BusyBox' `ash` with the same argument, wait for the command to conclude, and then exit with the same exit code. Let's use this version of the Git wrapper, if we have it. This requires git-for-windows/MINGW-packages#52 to work, and allows e.g. using a `ProxyCommand` with OpenSSH, after setting `SHELL` to point to the `ash.exe` file. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
reduce-mingits-size
branch
from
7c22364 to
798fe1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with git-for-windows/MINGW-packages#52, this addresses a couple of concerns raised in git-for-windows/git#1439 (comment) (and subsequent comments on that ticket).