[Vulkan] Fix compilation of vulkan-shaders-gen on w64devkit after e31a4f6
#8880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e31a4f6 broke compilation on w64devkit. Including `algorithm` seems to fix that.
4 tasks
mofosyne
added
Review Complexity : Low
0cc4m
approved these changes
Aug 6, 2024
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Aug 7, 2024
…e31a4f6` (ggml-org#8880) * Fix compilation issue in `vulkan-shaders-gen` ggml-org@e31a4f6 broke compilation on w64devkit. Including `algorithm` seems to fix that. * Guard it under `#ifdef _WIN32`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compilation issue introduced by e31a4f6 on w64devkit.
Seems like deliberately including
algorithmis enough.