Fix new line issue with chat template, disable template when in-prefix/suffix is set #8203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
added
the
Review Complexity : Low
slaren
approved these changes
Jun 30, 2024
Nexesenex
pushed a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jun 30, 2024
…x/suffix is set (ggml-org#8203) * preserve new line llama_chat_format_single * disable chat template if in-prefix/suffix is set * remove redundant change
MagnusS0
pushed a commit
to MagnusS0/llama.cpp-normistral-tokenizer
that referenced
this pull request
Jul 1, 2024
…x/suffix is set (ggml-org#8203) * preserve new line llama_chat_format_single * disable chat template if in-prefix/suffix is set * remove redundant change
Nexesenex
pushed a commit
to Nexesenex/croco.cpp
that referenced
this pull request
Jul 1, 2024
…x/suffix is set (ggml-org#8203) * preserve new line llama_chat_format_single * disable chat template if in-prefix/suffix is set * remove redundant change
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Jul 2, 2024
…x/suffix is set (ggml-org#8203) * preserve new line llama_chat_format_single * disable chat template if in-prefix/suffix is set * remove redundant change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re comment: #8198 (comment)
I ended up modifying
llama_chat_format_singlebecause changingllama_chat_apply_templatewill make it unnecessarily complicated (i.e. many templates will need to be patched)Also, when
--in-prefixor--in-suffixis set, we will disable chat template. That will allow users to use custom chat template.