Fix conversion of some BERT embedding models #6937
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BERT-based embedding models require the use of
convert-hf-to-gguf.py
to be converted from safetensors/PyTorch format to GGML. TheBertModel
class was missing logic that resolves unsupported datatypes, resulting in some models like acge_text_embedding failing withTypeError: Got unsupported ScalarType BFloat16
when running the linedata = data_torch.squeeze().numpy()
.This is rectified by converting unsupported datatypes to f32 - this is done in every other model class, so it was probably just missed in BERT models. This fix allows for satisfactory conversion and subsequent quantization, as seen in this GGUF quantization of acge_text_embedding created with this fix.
It's also literally just two lines of code, so unless converting tensors in BERT models specifically is undesirable, I hope this is an easy fix.