-
Notifications
You must be signed in to change notification settings - Fork 12k
[BUG fix]Building BUG: Fix a building error on windows+ROCm5.7+Cmake #6256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[bugfix] building error with Windows+ROCm5.7+Cmake Bug Description: function LOG defined in common/log.h used in ngram-cache.cpp possibly cause the building error on Windows Platform Building CXX object common/CMakeFiles/common.dir/ngram-cache.cpp.obj FAILED: common/CMakeFiles/common.dir/ngram-cache.cpp.obj llama/llama.cpp/common/./log.h:469:5: error: expected ')' function fprintf used in common/ngram-cache.cpp may cause the same error Solve Method: remove the including of log.h in ngram-cache.cpp remove the function call LOG in ngram-cache.cpp remove the function call fprintf in ngram-cache.cpp Changes to be committed: modified: common/ngram-cache.cpp
I observe no compilation issues on Windows (no GPU/CUDA). I don't understand why this is happening. The lines causing issues for |
Maybe this is some issue with For the |
If only remove these calls,the error still exists there is a part of error log, same as list in main description
|
I referenced other file(common.h) included log.h , and add a definition |
I have checked the PR #6273 solves this problem on my platform, so I will close this PR. |
[bugfix] building error with Windows+ROCm5.7+Cmake
Bug Description:
environment: Windows11 ROCm5.7 with (AMD 7800XT)
function LOG defined in common/log.h used in ngram-cache.cpp possibly cause the building error on Windows Platform
function fprintf used in common/ngram-cache.cpp may cause the same error
function LOG performed well in other obj, but the error raised when building ngram-cache.cpp.obj. Since the function fprintf raise the same error, so I guess that it was caused by ngram-cache related content.
I think removing these logs is a reasonable choice when the exact cause is unknown.
Solve Method:
Changes to be committed:
BUG Detail LOG
BUG Detail LOG2 ( fprintf will cause the same error)