server : allow continue edit on completion mode #3950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Nov 5, 2023
jhen0409
force-pushed
the
server-completion-edit
branch
from
bda68ea to
6c2c67d
Compare
olexiyb
pushed a commit
to Sanctum-AI/llama.cpp
that referenced
this pull request
Nov 23, 2023
* server : allow continue edit on completion mode * server : handle abort case in runCompletion * server : style improvement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the server completion mode UI more like OpenAI Playground with complete mode - we can continue edit the result and use it as a new prompt in the same UI state. For me this is very convenient and fast for editing my prompts.
Demo:
Screen.Recording.2023-11-05.at.10.33.17.mov
Show probabilities are also works:
I also disabled Markdownish in the completion mode, this make sure we can get the edit content correctly.