Skip to content

tests : add a C compliance test #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 30, 2023

Conversation

cebtenzzre
Copy link
Collaborator

This is a straightforward way to help developers realize when they make a change to llama.h that breaks C compatibility.
See PR #2847 for a recent example of this.

@cebtenzzre
Copy link
Collaborator Author

cebtenzzre commented Aug 28, 2023

Oops, the Makefile isn't pulling in the target unless you request it explicitly. I can't even run the tests target because it's been broken since at least edd4c14:

make: *** No rule to make target 'tests/test-tokenizer-0.cpp', needed by 'tests/test-tokenizer-0'.  Stop.
make: *** Waiting for unfinished jobs....

@ggerganov
Copy link
Member

Lets merge master and make sure CI is good

@ggerganov ggerganov merged commit 8494089 into ggml-org:master Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants