Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of checking the list of current nodes in
ggml_visit_parents()
to determine if a node has already been visited, avisited
flag is added toggml_tensor
.Unfortunately this requires resetting the
visited
flag to reuse the tensors in a different graph, and because in some cases graphs are built in multiple steps, it is not easy to do this automatically. Currently, this is done automatically when callingggml_graph_plan()
, but there may be some cases where it can cause current ggml code to fail silently.