-
Notifications
You must be signed in to change notification settings - Fork 12.2k
test-backend-ops: add support for specifying output format #14368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
bfa7a43
to
359d792
Compare
359d792
to
34500f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for specifying the output format (console or SQL) for the test-backend-ops tool and unifies logging via a new printer interface.
- Introduces a printer interface with concrete implementations for console and SQL output.
- Updates test evaluation functions and the CLI to use the printer for logging.
- Adds new command-line option "--output" along with helper functions to parse the output format.
Signed-off-by: Xiaodong Ye <[email protected]>
34500f9
to
679a141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my end I think these changes to test-backend-ops
would be fine but keep in mind that it's an important piece of the project with many stakeholders.
passed = false; | ||
|
||
// Set test time | ||
time_t t = time(NULL); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was added to record the timestamp (the same as llama-bench
), but I haven’t decided how to use it.
Signed-off-by: Xiaodong Ye <[email protected]>
Signed-off-by: Xiaodong Ye <[email protected]>
Thanks for pointing that out! I’ll add the recent contributors as reviewers. |
Make sure to read the contributing guidelines before submitting a PR
Testing Done
Edit (added
build_commit
andbuild_number
for future use):