Webui - change setText command from parent window to also send the message. #13309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
igardev
commented
May 5, 2025
igardev
commented
- setText command from parent window (for llama-vscode) now sends the message automatically.
- Upgrade packages versions to fix vulnerabilities with "npm audit fix" command.
added 2 commits
May 5, 2025 07:29
added 3 commits
May 5, 2025 08:16
…dit fix" command." This reverts commit 67687b7.
ngxson
requested changes
May 5, 2025
Comment on lines
46
to
52
| textarea.focus(); | ||
| if (onSend && data?.text) { | ||
| // Use setTimeout to ensure state updates are processed | ||
| setTimeout(() => { | ||
| onSend(); | ||
| }, 50); | ||
| } |
There was a problem hiding this comment.
Tbh I don't quite like this approach because it makes the logic looks kinda circular dependency.
A cleaner approach is to simply extend useChatTextarea to temporary hold a callback let's say textarea.onSubmit, then call it here:
Suggested change
| textarea.focus(); | |
| if (onSend && data?.text) { | |
| // Use setTimeout to ensure state updates are processed | |
| setTimeout(() => { | |
| onSend(); | |
| }, 50); | |
| } | |
| textarea.focus(); | |
| textarea.onSubmit(); |
There was a problem hiding this comment.
I agree. It is cleaner.
| @@ -132,7 +128,7 @@ export default function ChatScreen() { | |||
| scrollToBottom(true); | |||
| }; | |||
|
|
|||
| const sendNewMessage = async () => { | |||
| const sendNewMessage = useCallback(async () => { | |||
There was a problem hiding this comment.
no need useCallback here. We can simply update textarea.onSubmit = sendNewMessage each time
|
I'll push a commit to implement my suggestions |
|
@igardev can you test this? |
ngxson
reviewed
May 5, 2025
Comment on lines
+36
to
+38
| setTimeout(() => { | ||
| textarea.refOnSubmit.current?.(); | ||
| }, 10); // wait for setExtraContext to finish |
There was a problem hiding this comment.
Ok seems like if this is called right away, setExtraContext hasn't yet finished, hence why you don't see it. Can you give it a try now?
There was a problem hiding this comment.
It works now. Thanks!
ngxson
approved these changes
May 5, 2025
gabe-l-hart
added a commit
to gabe-l-hart/llama.cpp
that referenced
this pull request
May 6, 2025
* origin/master: (27 commits) llama : fix build_ffn without gate (ggml-org#13336) CUDA: fix bad asserts for partial offload (ggml-org#13337) convert : qwen2/3moe : set yarn metadata if present (ggml-org#13331) CUDA: fix --split-mode row for MMQ (ggml-org#13323) gguf-py : avoid requiring pyside6 for other scripts (ggml-org#13036) CUDA: fix logic for clearing padding with -ngl 0 (ggml-org#13320) sampling : Integrate Top-nσ into main sampling chain (and add it to the server) (ggml-org#13264) server : Webui - change setText command from parent window to also send the message. (ggml-org#13309) mtmd : rename llava directory to mtmd (ggml-org#13311) clip : fix confused naming ffn_up and ffn_down (ggml-org#13290) convert : bailingmoe : set yarn metadata if present (ggml-org#13312) SYCL: Disable mul_mat kernels for noncontiguous tensor b (ggml-org#13308) mtmd : add C public API (ggml-org#13184) rpc : use backend registry, support dl backends (ggml-org#13304) ggml : activate s390x simd for Q3_K (ggml-org#13301) llava/mtmd : fixes to fully support dl backends (ggml-org#13303) llama : build windows releases with dl backends (ggml-org#13220) CUDA: fix race condition in MMQ stream-k fixup (ggml-org#13299) CUDA: fix race condition in MMQ ids_dst (ggml-org#13294) vulkan: Additional type support for unary, binary, and copy (ggml-org#13266) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.