Skip to content

metal : opt-in compile flag for BF16 #10218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 8, 2024
Merged

metal : opt-in compile flag for BF16 #10218

merged 5 commits into from
Nov 8, 2024

Conversation

ggerganov
Copy link
Member

@ggerganov ggerganov commented Nov 8, 2024

fix #10205

BF16 does not seem to provide any benefits compared to F16, so to simplify things it will be an opt-in option. We want to have it enabled in the CI though in order to make sure it works.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Nov 8, 2024
@ggerganov ggerganov force-pushed the gg/metal-bf16-opt-in branch from 10d8004 to 29aee29 Compare November 8, 2024 10:44
@ggerganov ggerganov force-pushed the gg/metal-bf16-opt-in branch from dcb08e8 to 41f0cf6 Compare November 8, 2024 13:56
@ggerganov ggerganov force-pushed the gg/metal-bf16-opt-in branch from 52b9fb3 to 7ae02ad Compare November 8, 2024 14:52
@ggerganov ggerganov merged commit ec450d3 into master Nov 8, 2024
60 checks passed
@ggerganov ggerganov deleted the gg/metal-bf16-opt-in branch November 8, 2024 19:59
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
* metal : opt-in compile flag for BF16

ggml-ci

* ci : use BF16

ggml-ci

* swift : switch back to v12

* metal : has_float -> use_float

ggml-ci

* metal : fix BF16 check in MSL

ggml-ci
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
* metal : opt-in compile flag for BF16

ggml-ci

* ci : use BF16

ggml-ci

* swift : switch back to v12

* metal : has_float -> use_float

ggml-ci

* metal : fix BF16 check in MSL

ggml-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devops improvements to build systems and github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Metal bfloat kernel crash when using Swift package
2 participants