Skip to content

fix deepseek deseret regex #10062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dhiltgen
Copy link
Contributor

On windows compiled with gcc the c++ regex library failed to handle the characters

Resolves the problem first reported here - #7118 (comment)

On windows compiled with gcc the c++ regex library failed to handle
the characters
@slaren
Copy link
Member

slaren commented Oct 28, 2024

Please check the CI result, 4 - test-tokenizer-0-deepseek-llm (Failed) is failing.

@dhiltgen
Copy link
Contributor Author

Bummer. It looks like this approach only works with clang.

@dhiltgen dhiltgen closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants