Skip to content

kompute: add backend registry / device interfaces and Q4_K shader #10045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

slp
Copy link
Collaborator

@slp slp commented Oct 25, 2024

Get in line with the other backends by supporting the newer backend/device registry interfaces. While there, also add mul_mat_q4_k shader.

@github-actions github-actions bot added ggml changes relating to the ggml tensor library for machine learning Kompute https://github.com/KomputeProject/kompute/ labels Oct 25, 2024
@slp slp changed the title kompute: add backend registry / device interfaces kompute: add backend registry / device interfaces and Q4_K shader Oct 29, 2024
@slp slp marked this pull request as ready for review October 29, 2024 09:45
Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot review the other changes, I would suggest keeping them in a separate PR.

@slp
Copy link
Collaborator Author

slp commented Oct 29, 2024

I cannot review the other changes, I would suggest keeping them in a separate PR.

Thanks for the review. I've fixed the issues, cleaned up the code a little bit more, and dropped the commit adding the additional shader to deal with it in another PR.

Get in line with the other backends by supporting the newer
backend/device registry interfaces.

Signed-off-by: Sergio Lopez <[email protected]>
Copy link
Member

@slaren slaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation of the backend reg and device interfaces looks good, can be merged after resolving the conflicts from #10026.

@slp
Copy link
Collaborator Author

slp commented Oct 30, 2024

The implementation of the backend reg and device interfaces looks good, can be merged after resolving the conflicts from #10026.

Thanks, I've just rebased it on top of current master.

@slaren slaren merged commit 61408e7 into ggml-org:master Oct 30, 2024
52 checks passed
slaren pushed a commit that referenced this pull request Oct 30, 2024
Get in line with the other backends by supporting the newer
backend/device registry interfaces.

Signed-off-by: Sergio Lopez <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 15, 2024
Get in line with the other backends by supporting the newer
backend/device registry interfaces.

Signed-off-by: Sergio Lopez <[email protected]>
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Nov 18, 2024
Get in line with the other backends by supporting the newer
backend/device registry interfaces.

Signed-off-by: Sergio Lopez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ggml changes relating to the ggml tensor library for machine learning Kompute https://github.com/KomputeProject/kompute/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants