Make Kompute error verbose about unsupported types #10034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print the arch and quantization as strings.
slaren
reviewed
Oct 24, 2024
| @@ -9127,7 +9127,7 @@ static int llama_model_load(const std::string & fname, llama_model & model, llam | |||
| ) | |||
| )) { | |||
| // TODO(cebtenzzre): propagate this error outside of llama_load_model_from_file | |||
| LLAMA_LOG_WARN("%s: disabling Kompute due to unsupported model arch or quantization\n", __func__); | |||
| LLAMA_LOG_WARN("%s: disabling Kompute due to unsupported model arch (%s) or quantization (%s)\n", __func__, LLM_ARCH_NAMES.at(model.arch), llama_model_ftype_name(model.ftype).c_str()); | |||
There was a problem hiding this comment.
This warning will be removed in #10026, since the llama model loader will be able to offload weights only to backends that can actually use them, which should make this unnecessary. However, that PR will also remove support for backends that do not implement the backend reg and device interfaces, and currently only Kompute doesn't. If there is interest in keeping this backend in llama.cpp, it should be updated to implement these interfaces.
There was a problem hiding this comment.
Oh ok I can close this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print the arch and quantization as strings.