Broken build on MSYS2 #871
Comments
comex
added a commit
to comex/llama.cpp
that referenced
this issue
Apr 11, 2023
Mostly for msys2 and mingw64 builds, which are different from each other and different from standard Visual Studio builds. Isn't Windows fun? - Define _GNU_SOURCE in more files (it's already used in ggml.c for Linux's sake). - Don't use PrefetchVirtualMemory if not building for Windows 8 or later (mingw64 doesn't by default). But warn the user about this situation since it's probably not intended. - Check for NOMINMAX already being defined, which it is on mingw64. - Actually use the `increment` variable (bug in my `pizza` PR). - Suppress unused variable warnings in the fake pthread_create and pthread_join implementations for Windows. - (not Windows-related) Remove mention of `asprintf` from comment; `asprintf` is no longer used. Fixes ggml-org#871.
Merged
prusnak
pushed a commit
that referenced
this issue
Apr 11, 2023
Mostly for msys2 and mingw64 builds, which are different from each other and different from standard Visual Studio builds. Isn't Windows fun? - Define _GNU_SOURCE in more files (it's already used in ggml.c for Linux's sake). - Don't use PrefetchVirtualMemory if not building for Windows 8 or later (mingw64 doesn't by default). But warn the user about this situation since it's probably not intended. - Check for NOMINMAX already being defined, which it is on mingw64. - Actually use the `increment` variable (bug in my `pizza` PR). - Suppress unused variable warnings in the fake pthread_create and pthread_join implementations for Windows. - (not Windows-related) Remove mention of `asprintf` from comment; `asprintf` is no longer used. Fixes #871.
|
Kudos for the quick action !
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Commit: f963b63 Breaks the MSYS2 build with the following messages:
llama_util.h: In constructor 'llama_mmap::llama_mmap(llama_file*)': llama_util.h:213:9: error: 'WIN32_MEMORY_RANGE_ENTRY' was not declared in this scope 213 | WIN32_MEMORY_RANGE_ENTRY range; | ^~~~~~~~~~~~~~~~~~~~~~~~ llama_util.h:214:9: error: 'range' was not declared in this scope 214 | range.VirtualAddress = addr; | ^~~~~ llama_util.h:216:14: error: 'PrefetchVirtualMemory' was not declared in this scope 216 | if (!PrefetchVirtualMemory(GetCurrentProcess(), 1, &range, 0)) { | ^~~~~~~~~~~~~~~~~~~~~The text was updated successfully, but these errors were encountered: