Skip to content

Commit 9d4d14c

Browse files
committed
Address review comments
1 parent 3e4fc41 commit 9d4d14c

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

CMakeLists.txt

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -43,17 +43,11 @@ else()
4343
set(LLAMA_METAL_DEFAULT OFF)
4444
endif()
4545

46-
# TODO: fix this for Android CI
47-
# https://github.com/ggerganov/llama.cpp/pull/6716#issuecomment-2061509191
48-
#if (CMAKE_SYSTEM_NAME MATCHES "ANDROID")
49-
# set(LLAMA_LLAMAFILE_DEFAULT OFF)
50-
#else()
51-
# set(LLAMA_LLAMAFILE_DEFAULT ON)
52-
#endif()
53-
54-
# TODO: temporary disable until MoE is fixed
55-
# https://github.com/ggerganov/llama.cpp/pull/6716
56-
set(LLAMA_LLAMAFILE_DEFAULT OFF)
46+
if (CMAKE_SYSTEM_NAME MATCHES "ANDROID")
47+
set(LLAMA_LLAMAFILE_DEFAULT OFF)
48+
else()
49+
set(LLAMA_LLAMAFILE_DEFAULT ON)
50+
endif()
5751

5852
# general
5953
option(BUILD_SHARED_LIBS "build shared libraries" OFF)

sgemm.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -512,8 +512,8 @@ class tinyBLAS_Q0_ARM {
512512
for (int job = start; job < end; ++job) {
513513
int ii = m0 + job / xtiles * RM;
514514
int jj = n0 + job % xtiles * RN;
515-
D Cv[RN][RM] = {};
516-
for (int l = 0; l < k; l += KN)
515+
float32x4_t Cv[RN][RM] = {};
516+
for (int l = 0; l < k; ++l)
517517
for (int j = 0; j < RN; ++j)
518518
for (int i = 0; i < RM; ++i)
519519
Cv[j][i] = vmlaq_n_f32(Cv[j][i],
@@ -534,6 +534,7 @@ class tinyBLAS_Q0_ARM {
534534
inline int8x16_t load_lo(const block_q8_0 *b) {
535535
return vld1q_s8(b->qs);
536536
}
537+
537538
inline int8x16_t load_hi(const block_q8_0 *b) {
538539
return vld1q_s8(b->qs + 16);
539540
}
@@ -543,6 +544,7 @@ class tinyBLAS_Q0_ARM {
543544
vdupq_n_u8(0x0f))),
544545
vdupq_n_s8(0x8));
545546
}
547+
546548
inline int8x16_t load_hi(const block_q4_0 *b) {
547549
return vsubq_s8(vreinterpretq_s8_u8(vshrq_n_u8(vld1q_u8(b->qs), 4)),
548550
vdupq_n_s8(0x8));

0 commit comments

Comments
 (0)