Skip to content

Commit 7e986ec

Browse files
committed
add TODO comment
1 parent 2d66042 commit 7e986ec

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

ggml/src/ggml-cpu/vec.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -407,6 +407,8 @@ void ggml_vec_swiglu_f32(const int n, float * y, const float * x, const float *
407407
ggml_float ggml_vec_cvar_f32(const int n, float * y, const float * x, const float mean) {
408408
int i = 0;
409409
ggml_float sum = 0;
410+
// TODO: optimize to process the remaining elements in groups using the smaller vector sizes from AVX2 and SSE
411+
// ref: https://github.com/ggml-org/llama.cpp/pull/15953#pullrequestreview-3310928344
410412
#if defined(__AVX512F__) && defined(__AVX512DQ__)
411413
for (; i + 15 < n; i += 16) {
412414
__m512 val = _mm512_sub_ps(_mm512_loadu_ps(x + i),

0 commit comments

Comments
 (0)