Raw window handle support instead of winit #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
force-pushed
the
raw-handle
branch
3 times, most recently
from
4529059 to
fb1e74b
Compare
|
(tagging #295 because of the partial fix by specifying the |
grovesNL
approved these changes
Aug 21, 2019
| rendy-memory = { version = "0.4" } | ||
| rendy-descriptor = { version = "0.4" } | ||
| parking_lot = "0.9" | ||
| raw-window-handle = "0.1" |
There was a problem hiding this comment.
Technically I guess somebody could prefer for this to be optional too, but it's probably fine to always require it
| raw_window_handle::RawWindowHandle::IOS(h) => | ||
| instance.create_surface_from_uiview(raw.ui_view, cfg!(debug_assertions)), | ||
| #[cfg(all(target_os = "ios", feature = "gfx-backend-metal"))] | ||
| raw_window_handle::RawWindowHandle::MacOS(h) => |
There was a problem hiding this comment.
Did we also want to support gfx-backend-vulkan on macOS? (I don't think we need to block the PR on this, but probably worth mentioning since we added it to gfx-hal)
| WGPUSurfaceId wgpu_instance_create_surface_from_winit(WGPUInstanceId instance_id, | ||
| const WGPUWindow *window); | ||
| #endif | ||
|
|
||
| #if (defined(WGPU_LOCAL) && !defined(WGPU_BACKEND_GL)) |
There was a problem hiding this comment.
We should be able to remove the WGPUWindow workaround in cbindgen.toml too
|
Great notes! I added support for Vulkan on Mac and removed the Window workaround from cbindgen. |
bors bot
added a commit
that referenced
this pull request
Aug 21, 2019
301: Raw window handle support instead of winit r=grovesNL a=kvark This removes `winit` and paves the way for gfx-rs/wgpu-rs#64 Co-authored-by: Dzmitry Malyshau <[email protected]>
Canceled |
|
bors r=grovesNL |
bors bot
added a commit
that referenced
this pull request
Aug 21, 2019
301: Raw window handle support instead of winit r=grovesNL a=kvark This removes `winit` and paves the way for gfx-rs/wgpu-rs#64 Co-authored-by: Dzmitry Malyshau <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
winitand paves the way for gfx-rs/wgpu-rs#64