test(replay): Create test stubs for all replay frames and frame-data #50246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
ryan953
commented
Jun 2, 2023
There was a problem hiding this comment.
This is copied from the sdk, don't need to commit it because we can wait for an sdk release
ryan953
commented
Jun 2, 2023
There was a problem hiding this comment.
This is copied from the sdk, don't need to commit it because we can wait for an sdk release
ryan953
commented
Jun 2, 2023
static/app/utils/replays/types.tsx
Outdated
There was a problem hiding this comment.
thinking about moving types into utils/ instead of leaving it in views/`
Some will need to move from the old file into here, and others will be replaced outright with these.
billyvg
approved these changes
Jun 2, 2023
ryan953
commented
Jun 3, 2023
Comment on lines
134
to
146
| request?: { | ||
| _meta?: string[]; | ||
| body?: unknown; | ||
| headers?: Record<string, string>; | ||
| size?: number; | ||
| }; | ||
| requestBodySize?: number; | ||
| response?: { | ||
| _meta?: string[]; | ||
| body?: unknown; | ||
| headers?: Record<string, string>; | ||
| size?: number; | ||
| }; |
There was a problem hiding this comment.
request and response are added here. They're not in the SDK yet.
ryan953
commented
Jun 7, 2023
static/app/utils/replays/types.tsx
Outdated
There was a problem hiding this comment.
Of all the files added in this folder, this is the only one that needs to stick around. It'll be updated to import from the sdk.
ryan953
force-pushed
the
ryan953/ref-replay-test-mocks
branch
from
b627b38 to
e2afed1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.